[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-487450791 Hi @cloud-fan , @gatorsmile and @srowen , Appreciate if you can take a look the PR again. I enhanced

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-483065759 Hi @gatorsmile, Would you mind to review it again? I moved tests from sql/hive to sql/core as

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-479560769 Hi @gatorsmile, thanks for the review. * May I know where the migration guide? I am happy to

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-478570405 Hi @cloud-fan, appreciate if you could take a look this PR. I hope it makes sense. Best regards,

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-478308499 Hi @srowen, this PR is to preserve cache name and storage level when refresh a table. May I know if you

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-478202736 Hi @dongjoon-hyun, would you mind to also take a look the PR? If it is good, pls kindly help to merge.

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477636923 Hi @attilapiros , thanks for those review. just patched the PR accordingly. please review again.

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477267036 > Nit: avoid punctuation-free syntax for methods where the name is not an operator Thanks. Will

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477237397 Hi @attilapiros, I did not realize pushing my changes to the branch would trigger a build

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477218636 Hi @attilapiros , Thanks for the review and hints. I will fix them soon.

[GitHub] [spark] William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name URL: https://github.com/apache/spark/pull/24221#issuecomment-477216623 Hi @dongjoon-hyun, Many thanks. :)