[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2023-02-07 Thread via GitHub
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1099727909 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -3775,6 +3775,13 @@ object SQLConf { .booleanConf

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2023-02-03 Thread via GitHub
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1095663349 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4946,6 +4953,8 @@ class SQLConf extends Serializable with Logging { def

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-11-17 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1025413256 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -1040,6 +1040,14 @@ class ParquetSchemaSuite extends

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-11-17 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1025412863 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -1040,6 +1040,14 @@ class ParquetSchemaSuite extends

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-25 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1004137291 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -198,6 +205,31 @@ abstract class ParquetSchemaTest

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-25 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1004137291 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -198,6 +205,31 @@ abstract class ParquetSchemaTest

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-24 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1003756142 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -198,6 +205,31 @@ abstract class ParquetSchemaTest

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-23 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1002902562 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,10 @@ class

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-21 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1001477809 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,8 @@ class

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-20 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1000927574 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,8 @@ class

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-20 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1000890475 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,8 @@ class

[GitHub] [spark] awdavidson commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-20 Thread GitBox
awdavidson commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1000260756 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,8 @@ class