[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494064042 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -861,15 +862,22 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494071214 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala ## @@ -80,3 +80,11 @@ private[sql] case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494070910 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1020,16 +1039,38 @@ class Analyzer( // 3)

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494071037 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ## @@ -34,7 +34,7 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494064042 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -861,15 +862,22 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494064042 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -861,15 +862,22 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493470581 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala ## @@ -0,0 +1,231 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493466453 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/TableCapabilityCheck.scala ## @@ -43,7 +43,8 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493466003 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -260,19 +264,47 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493464663 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ## @@ -731,3 +732,11 @@ case class HiveTableRelation(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493462779 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1020,16 +1039,35 @@ class Analyzer( // 3)

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r492165991 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -895,10 +896,12 @@ class Analyzer( object

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r492169501 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r492168726 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r492168003 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r492166614 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1020,16 +1031,28 @@ class Analyzer( // 3)

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r492165991 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -895,10 +896,12 @@ class Analyzer( object

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490212612 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -846,9 +847,9 @@ class Analyzer( */

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490188876 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -846,9 +847,9 @@ class Analyzer( */

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490184548 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala ## @@ -78,6 +78,22 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490182757 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -260,19 +264,47 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490182111 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -174,7 +174,7 @@ case class CreateViewCommand(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490181759 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -39,7 +39,7 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490177455 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -846,9 +847,9 @@ class Analyzer( */

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489183117 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -260,19 +264,47 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489182868 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -475,6 +475,16 @@ class SessionCatalog(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489182354 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -942,6 +957,47 @@ class Analyzer( } }

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489182003 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -923,6 +925,19 @@ class Analyzer( case