dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-522709020
cc @cloud-fan I have made `EXPLAIN FORMATTED` to trigger the new explain
code. I have also switched the default of the new config we
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-522211877
retest this please
This is an automated message from the Apache Git
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-521901834
> For SQL, maybe we can use the new format for EXPLAIN FORMATTED
Currently FORMATTED is treated the same as EXTENDED, which is
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-521896970
@cloud-fan
> I'm OK to stay with the TreeNode string methods for now, but I do think we
should refactor it to a visitor pattern
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-521864064
@maropu
> sorry for cutting in, but I like the idea; if we had a
visiter-pattern-like logic for pringing plans (I think this can
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-521813753
@cloud-fan
> Maybe it's time to introduce a new framework for printing a query plan,
which is decoupled from the query plan itse
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-521136694
@cloud-fan One question .. how do i remove a tag from the plan ? Do we need
a clearTag method ?
---
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-520030191
@cloud-fan I have made a couple of change per your comment.
1) Include the "*" marker to indicate whole stage code gen on the main
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-517603962
@cloud-fan
> the *(1) prefix is pretty short. Shall we keep this in the head portion?
It can give you a general sense about how
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-517558722
@cloud-fan Sounds good Wenchen.
This is an automated message from t
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-517376314
@cloud-fan I was thinking for these operators we would override
verboseString(...) to print
1. Filter -> Input, Condition
2. S
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-517353897
@cloud-fan Thanks a lot for taking out the time for this PR.. Here are my
responses.
>the *(1) prefix is pretty short. Shall
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-515873516
retest this please
This is an automated message from the Apache Git
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-515380133
cc @cloud-fan If you can please take a look at this one when you have time..
---
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-514089641
> Is this expected to be enabled by default? How do we switch the format? It
seems some systems accpet options in an explain command
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-514081484
@maropu Thank you !! Yeah, we could add more stuff to the header portion of
the plan. I had discussed a bit with Sean on this and t
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-513597465
@maropu Thanks for your input. The current approach is based on DB2. I had
some preliminary discussion with @gatorsmile before start
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-511693834
retest this please
This is an automated message from the Apache Git
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-497913574
cc @gatorsmile @maryannxue
This is an automated message from the A
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN
command
URL: https://github.com/apache/spark/pull/24759#issuecomment-497779919
@ekoifman Thanks for your comment. So currently, `verboseString` has not
been implemented for all the operators. What we have is ver
20 matches
Mail list logo
