[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2021-03-11 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r592826875 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/GenerateExecBenchmark.scala ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2021-03-11 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r592825867 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/GenerateExecBenchmark.scala ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2021-03-06 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r588877950 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -144,9 +144,12 @@ case class GenerateExec( Seq.empty

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2021-03-06 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r588877871 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -144,9 +144,12 @@ case class GenerateExec( Seq.empty

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2021-02-28 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r584503039 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -51,6 +51,84 @@ class WholeStageCodegenSuite

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-16 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440636308 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -51,6 +51,86 @@ class WholeStageCodegenSuite

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-16 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440636071 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -51,6 +51,86 @@ class WholeStageCodegenSuite

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-16 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440635929 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -51,6 +51,86 @@ class WholeStageCodegenSuite

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-16 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440635513 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,14 +226,19 @@ case class GenerateExec( "0"

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440526114 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -51,6 +51,93 @@ class WholeStageCodegenSuite

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL]Enable codegen for GenerateExec

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440525221 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,18 +226,33 @@ case class GenerateExec( "0"

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL]Enable codegen for GenerateExec

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440525322 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,18 +226,33 @@ case class GenerateExec( "0"