[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-14 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r504562021 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,190 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-10 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r50281 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2721,6 +2721,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-07 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r501036503 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2721,6 +2721,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-04 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r499321425 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489259568 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489265261 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -507,33 +507,156 @@ class DataFrameSetOperationsSuite

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489257352 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486860843 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,101 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-11 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486860843 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,101 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-11 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486860843 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,101 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-08 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r485283227 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -50,18 +122,30 @@ object ResolveUnion extends

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482700803 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482698504 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,101 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482697548 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482697548 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482697548 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480496344 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480103193 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480103574 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480085360 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r479982337 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480087913 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala ## @@ -103,4 +104,30 @@ class StructTypeSuite extends

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480085690 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480085360 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r479982337 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r479982337 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r479980351 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r479979367 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package

[GitHub] [spark] maropu commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
maropu commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r479979494 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package