[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979436276 @gengliangwang @HyukjinKwon what do you think ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979429513 @cloud-fan In our case, the first function we looked into was `floor`/`ceil` but since it didn't take the scale parameter we had to look for other ways. So i believe adding a

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979224815 @cloud-fan I like the idea of adding `scale` parameter to `floor` and `ceil`. This would simulate the rounding mode `UP` and `down` for positive integers, but for negative

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979089012 @cloud-fan @gengliangwang I confirm `floor` and `ceil` don't match our use case. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979087156 Currently, we are relying on UDF for rounding, when i googled to do it via spark native methods, i found a lot of people have the same issue and it's not complex to support

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-974659848 @HyukjinKwon May I know the status of this PR please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-974659848 @HyukjinKwon May I know the status of this PR please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-973394467 @HyukjinKwon All tests are passing. I'm not sure why the Kubernetes integration test is failing, could you please kindly take a loot at it ? thanks ! -- This is an

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-969299145 @gengliangwang Could you please kindly take a look at this ? thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-969293378 **Test Fails on compatibility check against spark-sql_2.12:3.2.0!** but it is normal, no ? any idea how can we fix it ? error] spark-sql: Failed binary compatibility