[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15105 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65492/ Test PASSed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65492/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65490/ Test PASSed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65490/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65492/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread willb
Github user willb commented on the issue: https://github.com/apache/spark/pull/15105 Thanks for the feedback @srowen! I think 18e6bfe addresses everything from a code perspective, but it missed removing the comment about assuming that distinct words have distinct vector

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65490/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65453/ Test PASSed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65453/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65453/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65451/ Test FAILed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65451/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65451/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65448/ Test FAILed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65448/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread willb
Github user willb commented on the issue: https://github.com/apache/spark/pull/15105 @srowen Yes. But if we're querying for words similar to a given vector, then there's no word to filter out (and, indeed, no way to know which word we might want to filter out if multiple words might

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65448/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread willb
Github user willb commented on the issue: https://github.com/apache/spark/pull/15105 Can we assume in general that distinct words will not have identical (viz., by `.equals`) vector representations? I ask because the behavior in the current documentation (in that pyspark test I

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15105 I don't think you can assume that, though it will almost always be true. But I don't think the goal is to filter vectors of other words that happen to be identical. The point was just to filter the

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65443/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65443/ Test FAILed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65443/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread willb
Github user willb commented on the issue: https://github.com/apache/spark/pull/15105 Thanks, @hhbyyh. This is what I get for running `sbt "testOnly ..."` I'll push a fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65411/ Test FAILed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/15105 Hi @willb Good catch. This is a valid issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65411 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65411/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65411 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65411/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65409/ Test FAILed. ---

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65409 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65409/consoleFull)** for PR 15105 at commit

[GitHub] spark issue #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms no long...

2016-09-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15105 **[Test build #65409 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65409/consoleFull)** for PR 15105 at commit