Github user willb commented on the issue:
https://github.com/apache/spark/pull/15105
Can we assume in general that distinct words will not have identical (viz.,
by `.equals`) vector representations? I ask because the behavior in the
current documentation (in that pyspark test I linked above) assumes that you
don't want a word to turn up as a synonym for its own vector representation.
But this is impossible to enforce if we aren't guaranteed that distinct words
won't have identical vector representations.
This seems like a mostly reasonable assumption but it is definitely a
corner case that we might want to be robust to (or at least take note of). If
we can't accept this assumption, then we should figure out whether or not
changing the expected behavior in the documentation is acceptable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
