[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15795 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69555/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15795 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15795 **[Test build #69555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69555/consoleFull)** for PR 15795 at commit [`7e60b76`](https://github.com/apache/spark/commit/7e60b768147ac0ec04ed0259de494753a157dec0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15795 **[Test build #69555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69555/consoleFull)** for PR 15795 at commit [`7e60b76`](https://github.com/apache/spark/commit/7e60b768147ac0ec04ed0259de494753a157dec0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/15795 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15795 +1 for consolidating the examples. The boilerplate of creating a dataset and setting algorithm parameters takes up most of the example. I would create 1 example per algorithm which does transform, approxNearestNeighbor, and approxSimilarityJoin. The only reason not to would be if those demos required different datasets or algorithm settings, but I suspect they could be done in a unified manner. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15795 Could you please add tags "[ML][DOCS]" to the PR title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user Yunni commented on the issue: https://github.com/apache/spark/pull/15795 @sethah I think so. I have made changes for the docs but I haven't made changes to the examples. Please take a look when you get a chance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15795 Is this still targeted for 2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15795 Linking [https://issues.apache.org/jira/browse/SPARK-18392] since it will alter the public API for LSH --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user Yunni commented on the issue: https://github.com/apache/spark/pull/15795 @bravo-zhang @srowen I am OK to use the example in #15787. But I still think `approxNearestNeighbor` and `approxSimilarityJoin` are different algorithms and it would be easier for user to understand in separate examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user bravo-zhang commented on the issue: https://github.com/apache/spark/pull/15795 Examples are usually class/algorithm based, not interface/use case based. Maybe we can summarize the 5 classes into 2? Do you mind to modify the examples in #15787 after it is merged instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15795 Also this seems to overlap with https://github.com/apache/spark/pull/15787 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15795: [SPARK-18081] Add user guide for Locality Sensitive Hash...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15795 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
