Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
updated. Merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16404
Make sure you update the pull request and jira ticket description before
you merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16404
LGTM on the behavior
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
also cc @rxin to take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
I am fine to merge this at first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
Agree. Oracle behaves the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
Since Hive and postgres have same behavior on this, I'd like to follow them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71244/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #71244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71244/testReport)**
for PR 16404 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
It sounds like different RDBMS have different behaviors. Have we decided
which way we should follow?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #71244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71244/testReport)**
for PR 16404 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
how about we fix this in follow-up PR? Looks like the fix is not trivial.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
postgres handles `rand` in aggregate specially
```
cloud=# select random(), random();
random | random
---+---
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16404
Presto allows it and uses the same value of rand() computed during
projection for doing aggregation. Internally, every aggregation column is
hashed and hash values are appended to the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
MySQL treats them differently...
```SQL
mysql> select c1, concat(rand(), c1) from t1 group by c1;
+--+--+
| c1 | concat(rand(), c1) |
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
Oracle allows it. It sounds like they treat ` (username ||
dbms_random.string('a', 10))` in aggregate and group-by as the same expression.
```SQL
SQL> select (username ||
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
DB2 has such a limit. See the error message `SQL -583`:
http://www.ibm.com/support/knowledgecenter/SSEPGG_10.5.0/com.ibm.db2.luw.messages.sql.doc/doc/msql00583n.html
> The routine
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
How do other databases handle this case? Do they forbid using
non-deterministic expressions in GROUP BY, or give a better error message?
---
If your project is set up for it, you can reply to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
```Scala
sql("select a + rand() from testData2 group by a, a + rand()").explain(true)
```
After we merging this PR, I am afraid we might hitting a common
misunderstanding. Users
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
Found a bug filed in a JIRA
https://issues.apache.org/jira/browse/SPARK-19035. This PR does not resolves
it.
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16404
LGTM cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70754/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70753/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70753 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70753/testReport)**
for PR 16404 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70754 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70754/testReport)**
for PR 16404 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70754 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70754/testReport)**
for PR 16404 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70753 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70753/testReport)**
for PR 16404 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70617/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70617 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70617/testReport)**
for PR 16404 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70617 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70617/testReport)**
for PR 16404 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70603/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70603 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70603/testReport)**
for PR 16404 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70603 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70603/testReport)**
for PR 16404 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70597/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16404
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70597 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70597/testReport)**
for PR 16404 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16404
**[Test build #70597 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70597/testReport)**
for PR 16404 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16404
cc @rxin @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
45 matches
Mail list logo
