Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16866
Merged to master, branch-2.1, and branch-2.0.
Files involved in branch-1.6 were moved to new directories and made it hard
to cherry-pick. Created PR #16917 to backport this one to 1.6.
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16866
Branch-2.1 test compilation happens to be broken right now.
Trying to fix the compilation failure first.
---
If your project is set up for it, you can reply to this email and have your
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16866
Merging to master, branch-2.1, branch-2.0, and branch-1.6.
Conflicts occurred, I'm fixing them manually.
---
If your project is set up for it, you can reply to this email and have your
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
I prefer to just view these APIs as private since they are not in the
public docs. We have some similar APIs in SQL, such as classes in
`org.apache.spark.sql.execution`.
---
If your project is
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16866
In terms of API compatibility, I believe that the classes in
`network-common` are public simply due to being implemented in Java. However,
for the sake of argument let's say that someone _did_
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
> Actually, to clarify: @zsxwing, are you suggesting to check
currentThread().isInterrupted() in RetryingBlockFetcher?
In a second thought, I think your current approach is better, since we
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16866
Actually, to clarify: @zsxwing, are you suggesting to check
`currentThread().isInterrupted()` in `RetryingBlockFetcher`?
---
If your project is set up for it, you can reply to this email and
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16866
@zsxwing, as described in the PR description, if we throw an `IOException`
subclass from this then we need to modify `RetryingBlockFetcher` to have
special-case handling of
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
How about throwing InterruptedIOException and also setting the interrupted
state? E.g.,
```java
try {
cf.await();
} catch (InterruptedException e) {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16866
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72635/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16866
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16866
**[Test build #72635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72635/testReport)**
for PR 16866 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16866
**[Test build #72635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72635/testReport)**
for PR 16866 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16866
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16866
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16866
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72633/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16866
**[Test build #72633 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72633/testReport)**
for PR 16866 at commit
18 matches
Mail list logo
