Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17067
Thanks a lot Xiao.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73779/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73779/testReport)**
for PR 17067 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73779 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73779/testReport)**
for PR 17067 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
Generally, it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73722/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73722/testReport)**
for PR 17067 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17067
- Changes to the SQLQueryTestSuite framework to mask the exprId so I can
add the -ve cases as well using this framework.
- Added -ve test cases to the SQLQueryTestSuite framework and so removed
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73722/testReport)**
for PR 17067 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73622/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73622/testReport)**
for PR 17067 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73622 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73622/testReport)**
for PR 17067 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73561/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73561 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73561/testReport)**
for PR 17067 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17067
Thanks much Xiao for the review and comments.
I have made the following changes:
- Separated out the -ve cases from the +ve cases.
- Moved positive tests and also the cases that
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
We can move the remaining test cases to `SQLQueryTestSuite `, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73561/testReport)**
for PR 17067 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73494/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73494 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73494/testReport)**
for PR 17067 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73494 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73494/testReport)**
for PR 17067 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73479/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
Thank you for working on this! I like the coverage of qualified column
names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
Uh. Forgot one more point.
Could you move these test cases to our new end-to-end SQL query suite into
`SQLQueryTestSuite` ?
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17067
**[Test build #73479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73479/testReport)**
for PR 17067 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
Some test cases are negative; some test cases are expected to be supported.
Could you split them from the positive test cases? Now some test cases are
pretty large.
---
If your project is set
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17067
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
36 matches
Mail list logo
