Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
OK, let me try it, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17582
It would be good, but maybe the 2.1 backport will merge cleanly to 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
What about branch 2.0, do we also need to backport to it @vanzin ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17582
No luck with 2.1, please file a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17582
LGTM. Merging to master / 2.2, will try 2.1 and 2.0 too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
OK, thanks @tgravescs .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/17582
As @vanzin said I think this is fine for now to get this fixed quickly, but
filing a follow up jira makes sense.Actually this might be good to get into
the 2.1.1 release if they are going to
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
Thanks @tgravescs for your comments. Do you think it is a good idea to read
out ACLs when `mergeApplicationListing ` in
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/17582
changes lgtm. Did you file a jira to track changing to not use withSparkUI?
If user is downloading because the file is huge and takes a long time to
render or causes history server to have issue
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
Just update the description, please review again @vanzin , thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75998/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75998/testReport)**
for PR 17582 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17582
@jerryshao is the PR description still accurate? It seems you're not really
implementing 2 anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75998/testReport)**
for PR 17582 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17582
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75977/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75977/testReport)**
for PR 17582 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75977/testReport)**
for PR 17582 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75970/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75967/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75970/testReport)**
for PR 17582 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75967/testReport)**
for PR 17582 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75934/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75934/testReport)**
for PR 17582 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75934/testReport)**
for PR 17582 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
Thanks @tgravescs for your reply.
> on the history server I would expect spark.acls.enable=false and
spark.history.ui.acls.enable=true, I can see where that could be confusing,
perhaps
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/17582
so we should definitely fix the /api/v1/applications//logs to go
through the acls. It looks like it should be protected in
ApiRootResource.java. You have the app id so it needs to do something
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
@tgravescs , with the changes of history UI, REST API and web UI are now
mixed. The base URL to list all the apps is through REST API.
The key problem here is that in History Server we
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/17582
Been following this but haven't had time to do a proper review, but
@tgravescs since you brought up the UI vs API thing, as of 2.0 the UI gets it's
list from the API so that's where the security
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/17582
Sorry again the wording above and all the different configs are a bit
confusing to me as to what the real issues are here.
>Here actually has two list of acls, one is controlled by
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
@tgravescs @vanzin do you have any comment on this JIRA?
A compromise is that any user could see all the app list but detailed
information is still controlled by per app ACLs. But we
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17582
@tgravescs sorry for the confuse.
>if base URL's ACL (spark.acls.enable) is enabled but user A has no view
permission. User "A" cannot see the app list but could still access details of
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17582
> user configured with "spark.admin.acls" (or group) or
"spark.ui.view.acls" (or group), or the user who started SHS could list all the
applications, otherwise none of them can be listed
So
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/17582
Sorry but I'm confused by the explanation in the description. I didn't
completely follow what problems you are seeing that aren't intended and I don't
understand how you are proposing to fix.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75643/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75643/testReport)**
for PR 17582 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75643/testReport)**
for PR 17582 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75641/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75641 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75641/testReport)**
for PR 17582 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17582
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17582
**[Test build #75641 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75641/testReport)**
for PR 17582 at commit
48 matches
Mail list logo
