Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19451
Please change the title to `[SPARK-22181][SQL]Adds
ReplaceExceptWithNotFilter rule`
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19451
LGMT except a few minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gatorsmile I think i addressed all the comments, please let me know if i
missed anything, thanks.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83095/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #83095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83095/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #83095 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83095/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83022/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #83022 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83022/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@dilipbiswal @gatorsmile I included all your comments, please let me know
if i missed anything, thanks.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #83022 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83022/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82984/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82984 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82984/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82984 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82984/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82964/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82964 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82964/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82964 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82964/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82962/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82962 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82962/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82962 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82962/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82887/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82887/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82887/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gatorsmile please let me know if you have comments regarding the new
version of the rule, thanks.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82847/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82847 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82847/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82847 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82847/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gatorsmile done!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82815/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82815 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82815/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82812/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82812 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82812/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gatorsmile you are right! actually i forgot to push the updates in the
test suite. I pushed it now and the test cases are passing..
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82815 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82815/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
And could anybody please give me the needed rights to assign this task to
myself in the jira? thanks.
---
-
To unsubscribe,
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
In the previous version of the rule, the `InferFiltersFromConstraints` rule
added some additional filters (like 'col.isNotNull) after the filter condition
is flipped, so it filtered out the null
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82812 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82812/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gengliangwang thank you very much!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
Hi @sathiyapk , it is from `InferFiltersFromConstraints`.
---
-
To unsubscribe, e-mail:
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gatorsmile one quick question, could you please say which rule is
transforming the filter conditions like `'b === 2` to `'b.isNotNull && 'b ===
2` ? thanks!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82740/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82740 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82740/testReport)**
for PR 19451 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19451
If we have to do this all over again i'd put all rules in their own files.
Replace isn't really a great high level category because all rules at some
level replace something.
---
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@rxin I think it would be better to keep all the rules of the "Replace
Operators" batch in a single file. So if you prefer to keep the rule in a new
file, we can move all the replace operator
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gatorsmile
> Could you please add an end-to-end testsuite except.sql of
SQLQueryTestSuite.scala?
Please verify `except.sql ` and `except.sql.out` files are enough for the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82740/testReport)**
for PR 19451 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19451
Actually you already have it in the classdoc, so please just update the pr
description with it.
---
-
To unsubscribe, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19451
Can you update the pr description with an example plan before / after this
optimization, and also put that example in the comment section of the doc.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82703/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82703 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82703/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gengliangwang thanks!
I'll squash my commits into 2 if everything is fine..
---
-
To unsubscribe, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
LGTM.
@gatorsmile please help check again.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82703/testReport)**
for PR 19451 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
@sathiyapk You are right about the style, I didn't notice that.
I just left some more comments. I think this is good to me after you fix
them.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82645/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82645/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82645/testReport)**
for PR 19451 at commit
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gengliangwang Ready for a next review :)
> put case ... in a new line
Are your sure? I thought according to the coding style, while calling on a
partial function if there is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82606/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82606 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82606/testReport)**
for PR 19451 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
@sathiyapk Yes you're right, I have some misunderstandings.
Still, I have other comments.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82606 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82606/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82605/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82605 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82605/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19451
@gengliangwang thanks for your review. I pushed a new commit, please let me
know if it addresses your comments. And regarding
> Also please use semanticEquals instead of sameResult
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82605 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82605/testReport)**
for PR 19451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82590 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82590/testReport)**
for PR 19451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82590/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #82590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82590/testReport)**
for PR 19451 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19451
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
85 matches
Mail list logo
