Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
thanks, I'll fix `elt` too in following pr
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19977
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85535/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85535 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85535/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85535 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85535/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85511/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85511/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85511/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85495/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85495/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85495/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
ah, ok. good catch. I'll fix soon.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19977
Try
```
SELECT (col1 || (col3 || col4)) col
FROM (
SELECT
string(id) col1,
encode(string(id + 2), 'utf-8') col3,
encode(string(id + 3), 'utf-8') col4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85473/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85473/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85473/testReport)**
for PR 19977 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19977
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85454/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85454 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85454/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85451/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85451 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85451/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85454 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85454/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85451 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85451/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
I'll update tonight.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
@gatorsmile @gatorsmile ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85336/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85336/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
I got the overhead, so I pushed the commit to support it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85336/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
might have...I'll check the performance.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85329/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85329/testReport)**
for PR 19977 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19977
Yes; otherwise, it will introduce a performance regression, right?
---
-
To unsubscribe, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
I found the optimizer rule can't combine nested concat like;
```
scala>: psate
val df = sql("""
SELECT ((col1 || col2) || (col3 || col4)) col
FROM (
SELECT
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85329/testReport)**
for PR 19977 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19977
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85302/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85302 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85302/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85302 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85302/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85298/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85298 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85298/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85295/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85295 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85295/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85296/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85296/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85298 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85298/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85296/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
ok, all comments addressed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85295 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85295/testReport)**
for PR 19977 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19977
LGTM except the comments left above by @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85250/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85250/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85250/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85235/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85235 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85235/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85235 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85235/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85182/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85182/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85182 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85182/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85158 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85158/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85157/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85158/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85157/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85149/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85149 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85149/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85158 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85158/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85157 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85157/testReport)**
for PR 19977 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
@gatorsmile ok, all the fixes done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
Spark internally does not have a `CHAR` type.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85149 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85149/testReport)**
for PR 19977 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19977
As per hive implementation of CONCAT(), [these are the rules
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
ok, I will.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19977
@maropu We also should also correct `elt`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19977
You mean answers of mysql is unexpected? I think it's common these dbs get
different behaviors, while Spark mainly follows Hive.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19977
I found different behaviours in a string function `elt` though, is this
expected (binray output is a small surprise?);
```
hive> create table t(a binary, b binary);
hive> create view v
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19977
@maropu No need to re-trigger it. The failure is not caused by this PR.
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19977
Will review it tomorrow. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 151 matches
Mail list logo
