[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20373 **[Test build #86786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86786/testReport)** for PR 20373 at commit

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20373 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/353/

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20373 Thanks @ueshin and @HyukjinKwon , those fixes look reasonable to backport so sounds good to me. I'll run some tests too and then add to this PR. ---

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20373 FYI, I manually tried to port cloudpickle#132 and cloudpickle#145 only with corresponding test cases, and then check they were passed. ---

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20373 Nice catch! Yup, I think we should do it too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20373 We should also backport https://github.com/cloudpipe/cloudpickle/pull/132? They say that it fixes the regression that affects 0.4.2 and later. ---

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user rgbkrk commented on the issue: https://github.com/apache/spark/pull/20373 Cool, I can take a gander at this tomorrow (beyond my limited skim just now). --- - To unsubscribe, e-mail:

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20373 LGTM otherwise. @ueshin, I assume you were following this too. Did you had a change to take a look? Also, @rgbkrk, I think it would be great to have your look too .. It's basically a

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20373 I took a quick look for the commits and seems we should backport https://github.com/cloudpipe/cloudpickle/pull/145 too as looks introduced from

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20373 @holdenk and @HyukjinKwon , is there any further testing you guys can think that needs to be done to verify this is ok? ---

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20373 > Wait, so we left out cloudpickle#113 even though its in 0.4.2? That patch is in here and this exactly matches 0.4.2. I also manually verified that cloudpickle will pickle named

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20373 > the problem is with the standard pickling too, right? Yup. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20373 hmm sorry nvm. So not for this time, but maybe next time we could also copy the cloudpickle_test file over as well. --- - To

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20373 Wait, so we left out cloudpickle#113 even though its in 0.4.2? --- - To unsubscribe, e-mail: