Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r64868978
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -242,16 +263,19 @@ class ALSModel private[ml] (
}
}
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r64847886
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r64847897
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -430,10 +454,13 @@ class ALS(@Since("1.4.0") override val uid: String)
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r64847896
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -242,16 +263,19 @@ class ALSModel private[ml] (
}
}
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-220129049
Merged to master/branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-220017377
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-220017229
**[Test build #58776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58776/consoleFull)**
for PR 12762 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-220017380
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-220008852
**[Test build #58776 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58776/consoleFull)**
for PR 12762 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-220008113
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-219389391
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-219389390
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-219389308
**[Test build #58633 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58633/consoleFull)**
for PR 12762 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-219382438
**[Test build #58633 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58633/consoleFull)**
for PR 12762 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218682236
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218682239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218682139
**[Test build #58455 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58455/consoleFull)**
for PR 12762 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218675488
**[Test build #58455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58455/consoleFull)**
for PR 12762 at commit
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218571771
LGTM, except for maybe the generics in `checkNumericTypesALS` but that's
really minor.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218570425
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218570423
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218570242
**[Test build #58395 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58395/consoleFull)**
for PR 12762 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-218560077
**[Test build #58395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58395/consoleFull)**
for PR 12762 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-216869116
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-216869120
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-216868988
**[Test build #57759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57759/consoleFull)**
for PR 12762 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-216856660
**[Test build #57759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57759/consoleFull)**
for PR 12762 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-216856811
@yanboliang @holdenk @BenFradet @jkbradley I went ahead and just cast
user/item col to double before checked cast to support all numeric types for
user/item ids.
---
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61666720
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215758720
This looks good to me. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215646454
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215646452
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215646308
**[Test build #57319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57319/consoleFull)**
for PR 12762 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215639037
**[Test build #57319 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57319/consoleFull)**
for PR 12762 at commit
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61539561
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -58,6 +58,30 @@ object MLTestingUtils extends SparkFunSuite {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61539464
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -58,6 +58,30 @@ object MLTestingUtils extends SparkFunSuite {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61539432
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +513,60 @@ class ALSSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61539327
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215563782
LGTM except for a few minors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61502301
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -58,6 +58,30 @@ object MLTestingUtils extends SparkFunSuite {
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61501824
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -58,6 +58,30 @@ object MLTestingUtils extends SparkFunSuite {
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61497201
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +513,60 @@ class ALSSuite
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61494019
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61491217
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215539505
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215539507
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215539378
**[Test build #57267 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57267/consoleFull)**
for PR 12762 at commit
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61489680
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61487974
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61485772
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61485103
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -53,24 +53,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215529657
**[Test build #57267 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57267/consoleFull)**
for PR 12762 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12762#issuecomment-215528792
cc @sethah @BenFradet @srowen @jkbradley @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/12762
[SPARK-14891][ML] Add schema validation for ALS
This PR adds schema validation to `ml`'s ALS and ALSModel. Currently, no
schema validation was performed as `transformSchema` was never called in
55 matches
Mail list logo
