Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r18240973
--- Diff: extras/kinesis-asl/src/main/resources/log4j.properties ---
@@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727578
--- Diff: bin/run-example ---
@@ -29,7 +29,9 @@ if [ -n $1 ]; then
else
echo Usage: ./bin/run-example example-class [example-args] 12
echo
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727580
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727587
--- Diff: extras/kinesis-asl/pom.xml ---
@@ -0,0 +1,99 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+~ Licensed to the Apache Software Foundation
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727599
--- Diff: extras/kinesis-asl/pom.xml ---
@@ -0,0 +1,99 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+~ Licensed to the Apache Software Foundation (ASF)
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727602
--- Diff: extras/kinesis-asl/pom.xml ---
@@ -0,0 +1,99 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+~ Licensed to the Apache Software Foundation (ASF)
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727688
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727694
--- Diff: dev/audit-release/sbt_app_kinesis/build.sbt ---
@@ -0,0 +1,30 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15727693
--- Diff: dev/audit-release/audit_release.py ---
@@ -105,7 +105,7 @@ def get_url(url):
spark-core, spark-bagel, spark-mllib, spark-streaming,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50956263
QA tests have started for PR 1434. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17760/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50957227
QA results for PR 1434:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brpublic final class
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50973644
Thanks you very much @cfregly! I have merged this!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1434
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50974810
This was an epic pull request. Nice work, people.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pdeyhim commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50974841
Awsome work!! @tdas @cfregly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15685837
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessorUtils.scala
---
@@ -0,0 +1,79 @@
+/*
+ *
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15685828
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisStringRecordSerializer.scala
---
@@ -0,0 +1,44 @@
+/*
+ *
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15685855
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed to the Apache
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15685887
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed to the Apache
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15685865
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15690371
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisStringRecordSerializer.scala
---
@@ -0,0 +1,44 @@
+/*
+ *
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50938687
QA tests have started for PR 1434. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17701/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50938943
QA results for PR 1434:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brpublic final class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15721090
--- Diff: bin/run-example ---
@@ -29,7 +29,9 @@ if [ -n $1 ]; then
else
echo Usage: ./bin/run-example example-class [example-args] 12
echo -
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15721167
--- Diff: dev/audit-release/sbt_app_kinesis/build.sbt ---
@@ -0,0 +1,30 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15722812
--- Diff:
examples/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
---
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15722833
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15723335
--- Diff: extras/kinesis-asl/src/main/resources/log4j.properties ---
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15723363
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisCheckpointState.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15723355
--- Diff: extras/kinesis-asl/src/main/resources/log4j.properties ---
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15724763
--- Diff: extras/kinesis-asl/src/test/resources/log4j.properties ---
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15724783
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15724923
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessor.scala
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15726162
--- Diff: project/SparkBuild.scala ---
@@ -62,7 +62,7 @@ object SparkBuild extends PomBuild {
var isAlphaYarn = false
var profiles:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15726168
--- Diff: project/SparkBuild.scala ---
@@ -62,7 +62,7 @@ object SparkBuild extends PomBuild {
var isAlphaYarn = false
var profiles:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50951626
QA tests have started for PR 1434. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17736/consoleFull
---
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15726533
--- Diff:
extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
---
@@ -0,0 +1,187 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15726872
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15726898
--- Diff: bin/run-example ---
@@ -29,7 +29,9 @@ if [ -n $1 ]; then
else
echo Usage: ./bin/run-example example-class [example-args] 12
echo
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15631461
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15651823
--- Diff: project/SparkBuild.scala ---
@@ -62,7 +62,7 @@ object SparkBuild extends PomBuild {
var isAlphaYarn = false
var profiles:
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15651971
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15653238
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15654371
--- Diff: make-distribution.sh ---
@@ -196,6 +196,8 @@ cp -r $FWDIR/bin $DISTDIR
cp -r $FWDIR/python $DISTDIR
cp -r $FWDIR/sbin $DISTDIR
cp -r
Github user cfregly commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50786500
ah, gotcha matei. the examples aren't part of the core, so they can depend
on external libs. i'll make the change.
---
If your project is set up for it, you can reply
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15656394
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50792452
QA tests have started for PR 1434. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17589/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50792565
QA results for PR 1434:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brpublic final class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15657271
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisStringRecordSerializer.scala
---
@@ -0,0 +1,44 @@
+/*
+ *
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15657421
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessorUtils.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15668060
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15668098
--- Diff:
examples/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCount.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15668154
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15668266
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50819992
@pwendell Can you take a look at the pom, and other build stuff?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15670682
--- Diff: dev/audit-release/sbt_app_core/src/main/scala/SparkApp.scala ---
@@ -47,7 +47,14 @@ object SimpleApp {
System.exit(-1)
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15670661
--- Diff: dev/audit-release/sbt_app_core/src/main/scala/SparkApp.scala ---
@@ -47,7 +47,14 @@ object SimpleApp {
System.exit(-1)
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15670918
--- Diff: assembly/pom.xml ---
@@ -186,6 +186,16 @@
/dependencies
/profile
profile
+ idkinesis-asl/id
+
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15567656
--- Diff:
extras/spark-kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCount.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15567741
--- Diff:
extras/spark-kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCount.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15568250
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,345 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15568742
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,345 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15568964
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15568976
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15615786
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15616231
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15616323
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15617751
--- Diff: docs/streaming-programming-guide.md ---
@@ -467,6 +468,62 @@ For more details on these additional sources, see the
corresponding [API documen
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15617745
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15617770
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15617760
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15617773
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15618463
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15618507
--- Diff: project/SparkBuild.scala ---
@@ -60,9 +60,13 @@ object SparkBuild extends PomBuild {
var isAlphaYarn = false
var profiles:
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15618503
--- Diff: extras/spark-kinesis-asl/src/test/resources/log4j.properties ---
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15618546
--- Diff:
extras/spark-kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCount.java
---
@@ -0,0 +1,310 @@
+/*
+ *
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15618561
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala
---
@@ -0,0 +1,345 @@
+/*
+ * Licensed
Github user cfregly commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15620896
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50701651
QA tests have started for PR 1434. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17530/consoleFull
---
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623324
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623331
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623426
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623520
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50704814
Chris, thanks for this very thorough PR. One thought I have is that maybe
we should put the example in the `examples` package, and make that depend on
Kinesis. The
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623527
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623534
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623553
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15623547
--- Diff: project/SparkBuild.scala ---
@@ -62,7 +62,7 @@ object SparkBuild extends PomBuild {
var isAlphaYarn = false
var profiles:
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50443974
@pdeyhim can you take a look over this too when you have a chance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50511469
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50511485
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50512322
QA tests have started for PR 1434. This patch DID NOT merge cleanly!
brView progress:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50525716
QA results for PR 1434:br- This patch PASSES unit tests.brbrFor more
information see test
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50530784
Hey @cfregly,
My apologies for being so late to review this. Seems like the PR requires
merging with the master, probably because of changes to pom.xml. Would you
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15549163
--- Diff: extras/spark-kinesis-asl/pom.xml ---
@@ -0,0 +1,98 @@
+?xml version=1.0 encoding=UTF-8?
--- End diff --
Can you rename is the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15549239
--- Diff: bin/run-kinesis-example ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env bash
+
--- End diff --
@pdeyhim explained me that this script is
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15549518
--- Diff: extras/spark-kinesis-asl/pom.xml ---
@@ -0,0 +1,98 @@
+?xml version=1.0 encoding=UTF-8?
--- End diff --
Aah, I understand, you must
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15552530
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15552628
--- Diff:
extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1434#discussion_r15554012
--- Diff: extras/spark-kinesis-asl/pom.xml ---
@@ -0,0 +1,98 @@
+?xml version=1.0 encoding=UTF-8?
--- End diff --
Okay, I spoke to @pwendell and
1 - 100 of 134 matches
Mail list logo
