[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-11-03 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-153483685 Do you mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-11-03 Thread nssalian
Github user nssalian commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-153467686 What is the status of the PR? Seems no movement for a while. @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-11-03 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/1482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-02 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-136971893 I think it is necessary to merge the PR into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-136971880 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-136971892 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-136973684 [Test build #41928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41928/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-137032169 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-137032164 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-137031896 [Test build #41928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41928/console) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-136917245 What's the status of this patch? Is it still relevant after so many releases? @witgo @vanzin --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-97884669 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-97884647 [Test build #31427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31427/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-97884665 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-30 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/1482#discussion_r29440041 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -280,13 +280,18 @@ private[spark] class Executor( m

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-97842633 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-97842583 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-97843150 [Test build #31427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31427/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/1482#discussion_r29381930 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -280,13 +280,18 @@ private[spark] class Executor( m

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/1482#discussion_r29381924 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -280,13 +280,18 @@ private[spark] class Executor( m

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/1482#discussion_r29382009 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -701,6 +701,10 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-29 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-97588168 Well, this has been lingering here for a while. Looks sane though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-95061047 [Test build #30738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30738/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-22 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-95117217 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-95117546 [Test build #30750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30750/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-95144904 [Test build #30750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30750/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-95144915 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-95078711 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-95078684 [Test build #30738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30738/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-18 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-94215412 I actually wouldn't mind working on this - it's an issue near and dear to my heart :-). What's the best way to pick up the ball here ? I could just make a new PR - the

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-94215242 @ilganeli I think that this has largely stalled because this is a somewhat complicated-to-review change (as the discussion above shows, it can be tricky to make sure

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-04-17 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-94074662 @JoshRosen There's been no activity here for over 5 months - is this still alive? If not, I wouldn't mind finishing the job since I ran into this exact issue and could

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-84830436 [Test build #28980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28980/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-84830480 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2015-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-84812073 [Test build #28980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28980/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-67799173 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-61362218 [Test build #22693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22693/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-61363387 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-61363384 [Test build #22693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22693/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-11-01 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-61363413 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-61363474 [Test build #22694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22694/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-61365142 [Test build #22694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22694/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-61365144 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-09-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-54875511 @aarondav Do you have an example scenario where this patch prevents OOM reporting? Really, the only change here is wrapping the exception logging / reporting with `if

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-09-08 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-54915526 Well, I mean, this is our attempt to tell people what happened: ``` execBackend.statusUpdate(taskId, TaskState.FAILED, ser.serialize(reason)) ```

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-09-08 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-54917849 @aarondav I understand what you mean,I will submit the relevant code tomorrow. BTW,most of the OOM are present in deserialization process. --- If your project is set

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-54700201 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19887/consoleFull) for PR 1482 at commit

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-09-05 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-54700237 Could this suppress the OOM message from getting to the driver? I thought there was special handling for these messages (error code). This could result in executor died

[GitHub] spark pull request: [SPARK-2491] Don't handle uncaught exceptions ...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1482#issuecomment-54701544 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19887/consoleFull) for PR 1482 at commit