Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-55347720
2 logj4j properties files does make people confusing, I will try to update
the code, let's see if we can find a simple way to reuse the `log4j.properties`.
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54930604
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20023/consoleFull)
for PR 2263 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-55062500
Oh, okay thanks for explaining this! My inclination would be to update our
code to read from `log4j.properties` instead, unless there is some compelling
reason not to.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54916301
Its not really clear to me what this buys over the log4j.template that is
already there. I'm also not sure what the xsl file is for. Finally an empty
hive-site.xml
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54922757
@marmbrus those files are just a hint for users if they want to change some
of the default settings. Probably not everybody knows what files exactly they
should
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54923120
I'd agree that at least `hive-log4j.properties.template` should be good to
have. Partly because I myself had once been confused by this a lot...
---
If your project
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54925323
Thank you @liancheng , I've updated the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54927090
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20023/consoleFull)
for PR 2263 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096828
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096824
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096833
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54410818
I know that `hive-log4j.properties.template` is copied from Hive, but this
file really makes me itchy...
Besides that, I think these are generally good to
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17097013
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54424705
Thanks for reviewing this, you're right, the log4j configuration template
mainly for Hive usage (particularly for MapReduce), I've updated the code and
keep it
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54520406
Not all `.properties` files are ignored by RAT, it's controlled by
`.rat-excludes`, you may add `hive-log4j.properties.template` there.
---
If your project is set up
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54565805
Thank you @liancheng . I didn't notice that file previously. :)
test this please.
---
If your project is set up for it, you can reply to this email and
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/2263
[SPARK-3393] [SQL] add configuration template for HQL users
User may be confused for the HQL logging configurations, we'd better
provide a default templates.
You can merge this pull
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54407664
@liancheng, this is not change of any code, but kind of hint for the user
of HQL, I was asked couple of times for the configuration files, hope it
helpful. Any
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096823
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096830
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096834
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096826
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2263#discussion_r17096836
--- Diff: conf/hive-log4j.properties.template ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
23 matches
Mail list logo
