Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r18175957
--- Diff: core/src/main/scala/org/apache/spark/network/netty/protocol.scala
---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-57209924
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20986/consoleFull)
for PR 2330 at commit
[`f23e682`](https://github.com/ap
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r18121216
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClientFactory.scala ---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Found
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17653172
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClientFactory.scala ---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software F
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17652889
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockServer.scala ---
@@ -121,18 +91,18 @@ class BlockServer(conf: NettyConfig, dataProvider:
B
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17650983
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClientFactory.scala ---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Found
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17650877
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClientFactory.scala ---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software F
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55858115
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20452/consoleFull)
for PR 2330 at commit
[`088ed8a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55856201
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20451/consoleFull)
for PR 2330 at commit
[`a79a259`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55854376
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20452/consoleFull)
for PR 2330 at commit
[`088ed8a`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55851944
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20451/consoleFull)
for PR 2330 at commit
[`a79a259`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55483917
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20256/consoleFull)
for PR 2330 at commit
[`29fe0cc`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55482859
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20256/consoleFull)
for PR 2330 at commit
[`29fe0cc`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55472666
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/82/consoleFull)
for PR 2330 at commit
[`8295561`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55468445
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/82/consoleFull)
for PR 2330 at commit
[`8295561`](https://github.com/ap
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17502935
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -185,26 +223,34 @@ final class ShuffleBlockFetcherIterator(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55376546
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20215/consoleFull)
for PR 2330 at commit
[`8295561`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55371346
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20215/consoleFull)
for PR 2330 at commit
[`8295561`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55369434
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20206/consoleFull)**
after a configured wait of `120m`.
---
If your project i
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17463888
--- Diff: core/src/main/scala/org/apache/spark/network/netty/protocol.scala
---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17463602
--- Diff: core/src/main/scala/org/apache/spark/network/netty/protocol.scala
---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17463593
--- Diff: core/src/main/scala/org/apache/spark/network/netty/protocol.scala
---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17463574
--- Diff: core/src/main/scala/org/apache/spark/network/netty/protocol.scala
---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17463515
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClientFactory.scala ---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Found
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17463503
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClientFactory.scala ---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Found
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55362560
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20206/consoleFull)
for PR 2330 at commit
[`6ddaa5d`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55357993
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20191/consoleFull)**
after a configured wait of `120m`.
---
If your project i
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17460170
--- Diff: core/src/main/scala/org/apache/spark/network/netty/protocol.scala
---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55351771
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20191/consoleFull)
for PR 2330 at commit
[`55266d1`](https://github.com/ap
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17459366
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -185,26 +223,34 @@ final class ShuffleBlockFetcherIterator(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55222920
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20138/consoleFull)
for PR 2330 at commit
[`6e84cb2`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55219321
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20137/consoleFull)
for PR 2330 at commit
[`d135fa3`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55219255
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20138/consoleFull)
for PR 2330 at commit
[`6e84cb2`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55216364
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20137/consoleFull)
for PR 2330 at commit
[`d135fa3`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55216326
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/54/consoleFull)
for PR 2330 at commit
[`b32c3fe`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55213524
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/54/consoleFull)
for PR 2330 at commit
[`b32c3fe`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55213274
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20131/consoleFull)
for PR 2330 at commit
[`b32c3fe`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55213214
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20131/consoleFull)
for PR 2330 at commit
[`b32c3fe`](https://github.com/ap
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55077449
@colorant you probably would be interested in this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55048008
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20053/consoleFull)
for PR 2330 at commit
[`dd783ff`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55041582
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20053/consoleFull)
for PR 2330 at commit
[`dd783ff`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55015796
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20047/consoleFull)
for PR 2330 at commit
[`9b3b397`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55008576
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20047/consoleFull)
for PR 2330 at commit
[`9b3b397`](https://github.com/ap
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-55004934
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-54940550
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20029/consoleFull)
for PR 2330 at commit
[`9b3b397`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2330#issuecomment-54935715
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20029/consoleFull)
for PR 2330 at commit
[`9b3b397`](https://github.com/ap
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17285939
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClientHandler.scala ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Founda
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/2330
[SPARK-3453] [WIP] Refactor Netty module to use BlockTransferService.
Also includes some partial support for uploading blocks.
You can merge this pull request into a Git repository by running:
$ g
48 matches
Mail list logo
