Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63023457
[Test build #23352 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23352/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63023461
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63025874
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63026569
[Test build #23362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23362/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63043183
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63043173
**[Test build #23362 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23362/consoleFull)**
for PR 2991 at commit
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63117684
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63118606
[Test build #23380 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23380/consoleFull)
for PR 2991 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63129819
[Test build #23380 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23380/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63129827
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63139795
Alright, I am merging this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63153874
Yes, I will, thanks a lot, greatly appreciate your help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62860980
[Test build #23300 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23300/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62860993
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62862109
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62862783
[Test build #23305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23305/consoleFull)
for PR 2991 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62876612
**[Test build #23305 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23305/consoleFull)**
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62876618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62976670
@jerryshao Here is another round of changes from me.
You correctly identified a flaw in the lock logic in the last change I
made. I played around with different
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62982811
I did more refactoring for Refactoring 2, to create
https://github.com/jerryshao/apache-spark/pull/8 . This is what I finally
recommend for merging. Please take a look. I
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62993250
OK, I will, thanks a lot, greatly appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62996965
[Test build #23345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23345/consoleFull)
for PR 2991 at commit
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62997454
Lets see if this passes jenkins, I hadnt tried that yet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62998448
Hi TD, this test is so flaky, it fails several times in my local test:
```
- block addition, block to batch allocation and cleanup with write ahead
log ***
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63002988
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63002982
[Test build #23345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23345/consoleFull)
for PR 2991 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63017519
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-63017550
[Test build #23352 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23352/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62685127
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62685122
[Test build #23253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23253/consoleFull)
for PR 2991 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20210141
--- Diff:
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/ReliableKafkaStreamSuite.scala
---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20210320
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20215912
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20247329
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20247390
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20265416
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20265529
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20265849
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20265751
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62834197
[Test build #23297 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23297/consoleFull)
for PR 2991 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62834301
[Test build #23297 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23297/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62834307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20270965
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20271138
--- Diff:
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/ReliableKafkaStreamSuite.scala
---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20271214
--- Diff:
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/ReliableKafkaStreamSuite.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20271438
--- Diff: project/MimaExcludes.scala ---
@@ -85,6 +85,10 @@ object MimaExcludes {
org.apache.hadoop.mapred.SparkHadoopMapRedUtil),
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62838566
@jerryshao Please enable the unit tests that i commented out and test
whether they work correctly. Thanks for helping out, sorry I could not get it
to work completely
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62840906
I think there's still a synchronizing issue, would you mind taking a look
at the comment here in (https://github.com/jerryshao/apache-spark/pull/5),
thanks a lot.
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62840663
I will do it. Thanks a lot for your refactor work and review, very
appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20272068
--- Diff: project/MimaExcludes.scala ---
@@ -85,6 +85,10 @@ object MimaExcludes {
org.apache.hadoop.mapred.SparkHadoopMapRedUtil),
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20272077
--- Diff:
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/ReliableKafkaStreamSuite.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62849975
[Test build #23300 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23300/consoleFull)
for PR 2991 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62850049
Hi TD, I've made some changes:
1. small code styles and comment changes.
2. Re-enable JavaKafkaStreamSuite, previous change makes Java related test
ignore,
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20139202
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62522054
Things to do for this PR
1. Revert the change of separating out KafkaReceiver to minimize diff. Do
not want anything to affect the main code path.
2. Do not use
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20139743
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62523259
Greatly appreciate your comments, thanks a lot. I will change the code as
you suggested.
---
If your project is set up for it, you can reply to this email and have
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62530387
I have merged #1420 but github has not synced yet. If it does not update
soon, you can use the master branch of the real apache git repo to get the
latest changes.
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20196611
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaInputDStream.scala
---
@@ -53,112 +46,17 @@ class KafkaInputDStream[
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20197017
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62669315
[Test build #23245 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23245/consoleFull)
for PR 2991 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62674043
Hi TD, I just updated the code as you suggested, would you mind taking a
look at it.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62674113
[Test build #23250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23250/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62675074
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62675072
[Test build #23245 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23245/consoleFull)
for PR 2991 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62675496
[Test build #23251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23251/consoleFull)
for PR 2991 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62678538
[Test build #23253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23253/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62679992
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62679987
[Test build #23250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23250/consoleFull)
for PR 2991 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62682114
[Test build #23251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23251/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62682120
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62352709
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62352704
[Test build #23142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23142/consoleFull)
for PR 2991 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62357452
[Test build #23144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23144/consoleFull)
for PR 2991 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62357457
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62452662
@jerryshao This is a very good observation. I think this is going to be an
experimental update, it is okay to do it this way for now. If there are issues
with large kafka
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62486799
OK, got it, thanks a lot. I will add this class with experiment annotation.
For the performance comparison, we're still under test, some tuning and
configuration
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20128588
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaInputDStream.scala
---
@@ -53,112 +46,17 @@ class KafkaInputDStream[
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20129302
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20129324
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20129828
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20129842
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20129945
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20129965
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20130143
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20130193
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/BlockGenerator.scala
---
@@ -80,9 +89,10 @@ private[streaming] class BlockGenerator(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20130229
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20130302
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62499225
I have made comments on that PR #1420, I will merge that as soon as you
have made the changes. And then please update this PR, both receivers. BTW, for
simplifying stuff
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20131105
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaUtils.scala
---
@@ -71,7 +71,8 @@ object KafkaUtils {
topics:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20131127
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20134004
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaReceiver.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62347257
[Test build #23142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23142/consoleFull)
for PR 2991 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62347765
Hi @tdas , thanks a lot for your comments. I've addressed all the comments
you mentioned before. Would you mind taking a look at the updated version?
Thanks a lot.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62350594
[Test build #23144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23144/consoleFull)
for PR 2991 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r20003429
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r19992762
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/BlockGenerator.scala
---
@@ -80,9 +89,10 @@ private[streaming] class BlockGenerator(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r19992880
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2991#discussion_r19992945
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the
1 - 100 of 125 matches
Mail list logo
