[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64526546 [Test build #23884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23884/consoleFull) for PR 3468 at commit

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64536426 [Test build #23884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23884/consoleFull) for PR 3468 at commit

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64671123 @brkyvz Thanks! I've merged this into master. Will submit another PR for branch-1.2. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/3468 [SPARK-4614][MLLIB] Slight API changes in Matrix and Matrices Before we have a full picture of the operators we want to add, it might be safer to hide `Matrix.transposeMultiply` in 1.2.0. Another

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64510830 [Test build #23870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23870/consoleFull) for PR 3468 at commit

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3468#discussion_r20916331 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala --- @@ -112,4 +116,50 @@ class MatricesSuite extends FunSuite {

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64515054 Looks good to me! Just made one comment, no biggie though, it's fine as is (but if you decide to change it, there are 4 exact copies of it). One comment/question about

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64515619 [Test build #23870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23870/consoleFull) for PR 3468 at commit

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64515623 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3468#discussion_r20920325 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala --- @@ -112,4 +116,50 @@ class MatricesSuite extends FunSuite {

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64526447 @brkyvz `XORShiftRandom` implements `Random`. So users can use it directly. Using seed will create problems when we want to generate a sequence of matrices, e.g.,