Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-72568306
OK, I will close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user chenghao-intel closed the pull request at:
https://github.com/apache/spark/pull/3780
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70921844
I kind of like a proposal like that, but we need to make it Java friendly
as well.
---
If your project is set up for it, you can reply to this email and have your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70617731
The changes lgtm. I left couple small comments. Do you mind fixing those?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r23207210
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDDLike.scala
---
@@ -68,12 +68,28 @@ private[sql] trait SchemaRDDLike {
/**
* Saves
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70731684
@rxin what about the question of `append`, `overwrite`, `error`? Do we
want to expose all three for these types of interfaces?
---
If your project is set up for it,
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70765307
For my understanding, `insertInto` works in the ways of `create new`,
`append` or `overwrite` already, but it doesn't give user an option, which
allow throwing
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70767766
Or probably we can cleanup those APIs, kind of like:
```
trait Mode
object Append extends Mode
object Create extends Mode
object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70767371
[Test build #25860 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25860/consoleFull)
for PR 3780 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70776319
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-70776314
[Test build #25860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25860/consoleFull)
for PR 3780 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r23207087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala ---
@@ -151,15 +151,20 @@ private[sql] object ParquetRelation {
*
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r23206838
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala ---
@@ -179,9 +184,24 @@ private[sql] object ParquetRelation {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-69541870
[Test build #25409 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25409/consoleFull)
for PR 3780 at commit
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r22795027
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDDLike.scala
---
@@ -68,12 +68,29 @@ private[sql] trait SchemaRDDLike {
/**
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-69551534
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-69551518
[Test build #25409 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25409/consoleFull)
for PR 3780 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r22765228
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDDLike.scala
---
@@ -68,12 +68,29 @@ private[sql] trait SchemaRDDLike {
/**
* Saves
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r22762698
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDDLike.scala
---
@@ -68,12 +68,29 @@ private[sql] trait SchemaRDDLike {
/**
*
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-69475850
/cc @rxin
More API questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r22278028
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -199,11 +199,15 @@ private[sql] abstract class
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3780#discussion_r22278489
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -199,11 +199,15 @@ private[sql] abstract class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68083563
[Test build #24802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24802/consoleFull)
for PR 3780 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68086500
[Test build #24802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24802/consoleFull)
for PR 3780 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68086501
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/3780
[SPARK-4945] [SQL] Add overwrite option support for
SchemaRDD.saveAsParquetFile
You can merge this pull request into a Git repository by running:
$ git pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68022423
[Test build #24755 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24755/consoleFull)
for PR 3780 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68022466
[Test build #24755 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24755/consoleFull)
for PR 3780 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68022467
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68024602
[Test build #24758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24758/consoleFull)
for PR 3780 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68028615
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3780#issuecomment-68028612
[Test build #24758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24758/consoleFull)
for PR 3780 at commit
32 matches
Mail list logo
