[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-03 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72613931 Going to merge since tests passed previously, and the latest failure was due to a flaky test in streaming. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72613282 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72613272 [Test build #26633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26633/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72601872 I don't know whether MiMa actually checks our Java classes, so that might be another side-benefit of porting this back to Scala. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72601740 LGTM; this is a pretty straightforward change. Compared to implementing this in Java, this gains the benefit of having this class's docs appear in Scaladoc. I guess

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72600044 [Test build #26614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26614/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72600182 [Test build #26614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26614/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72600186 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72601943 [Test build #26618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26618/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72602375 [Test build #26620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26620/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72606843 [Test build #26620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26620/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72606849 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72608063 [Test build #26633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26633/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72607731 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72607656 [Test build #26618 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26618/consoleFull) for PR 4324 at commit

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4324#issuecomment-72607660 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4324#discussion_r23984946 --- Diff: core/src/test/java/test/org/apache/spark/JavaTaskCompletionListenerImpl.java --- @@ -15,9 +15,10 @@ * limitations under the License. */

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/4324 [SPARK-5549] Define TaskContext interface in Scala. So the interface documentation shows up in ScalaDoc. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4324#discussion_r23985360 --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala --- @@ -15,112 +15,116 @@ * limitations under the License. */

[GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4324#discussion_r23985377 --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala --- @@ -15,112 +15,116 @@ * limitations under the License. */