Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83950252
@yanboliang Adding a check for return value at [this line] [1] should be
enough.
[1]:
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-84232332
PS: #5107 has also been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-84232316
Thanks, merged into master and branch-1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4610
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-84065407
@liancheng Please review my fix for ParquetRelation2 in #5107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83433562
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83399347
[Test build #28860 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28860/consoleFull)
for PR 4610 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83433542
[Test build #28860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28860/consoleFull)
for PR 4610 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83532036
@yhuai Thanks for cc-ing me this. Although `ParquetRelation2` checks for
exception, it doesn't check return value of `fs.delete`, and thus suffer the
same issue.
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83545467
@yhuai Thank you for your comments on this PR
@liancheng If this LGTM, can I open another PR for ```ParquetRelation2```
and work on it?
---
If your project is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83548628
@yanboliang Sure, please go ahead. I'm trying to verify this issue locally.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-82816330
[Test build #28784 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28784/consoleFull)
for PR 4610 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-82816363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-82787234
[Test build #28784 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28784/consoleFull)
for PR 4610 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-83272562
Thank you for the update! It's very close. I think we want to do the same
thing for `ParquetRelation2`. Is it possible to add a test for this?
cc @liancheng
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r26726093
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,21 @@ private[sql] class DefaultSource
mode match {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r26726099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,21 @@ private[sql] class DefaultSource
mode match {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r26726167
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,21 @@ private[sql] class DefaultSource
mode match {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r26726286
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -110,7 +122,11 @@ private[sql] case class JSONRelation(
if
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r26726280
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,21 @@ private[sql] class DefaultSource
mode match {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81588212
[Test build #28646 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28646/consoleFull)
for PR 4610 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81567278
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81583301
[Test build #28645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28645/consoleFull)
for PR 4610 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81618205
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81559306
[Test build #28643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28643/consoleFull)
for PR 4610 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81618177
[Test build #28645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28645/consoleFull)
for PR 4610 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r26511261
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,17 @@ private[sql] class DefaultSource
mode match {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81567253
[Test build #28643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28643/consoleFull)
for PR 4610 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81626078
[Test build #28646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28646/consoleFull)
for PR 4610 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-81626136
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-79666339
Sorry for not following it. I will investigate it and reproduce the error
reported in jira. I should have more ideas on how we want to have the change
early next week.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-79517469
@yhuai what is the status here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r2537
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,17 @@ private[sql] class DefaultSource
mode
Github user hackingdata8 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r24989501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,17 @@ private[sql] class DefaultSource
mode
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r24922476
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,17 @@ private[sql] class DefaultSource
mode match {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-74494628
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4610#issuecomment-74494622
[Test build #27551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27551/consoleFull)
for PR 4610 at commit
37 matches
Mail list logo
