Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110628126
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110628109
[Test build #34564 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34564/console)
for PR 6735 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110677571
It's because `enclosingObject` in `instantiateClass` is null. The bytecodes
in constructor will check the first field:
```
public
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110731067
Heh, well it's supposed to be used when in the `spark-shell` I suppose.
However I agree that it seems to have not been used for a long time,
accidentally.
I
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32113419
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -109,7 +109,16 @@ private[spark] object ClosureCleaner extends Logging {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110740642
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110747493
[Test build #34594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34594/consoleFull)
for PR 6735 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110725471
The issue is that if a closure is cleaned twice, when cleaning the closure
at the second time, the `$outer` of this closure may have already been set to
`null`. Then
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110739267
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110746847
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110746849
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110746988
[Test build #34595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34595/consoleFull)
for PR 6735 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32102012
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -109,7 +109,16 @@ private[spark] object ClosureCleaner extends Logging {
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110674061
Interesting, I'd love to hear that this is the fix. The current failure is:
```
[info] - clean complicated nested non-serializable closures *** FAILED ***
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110788515
[Test build #34595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34595/console)
for PR 6735 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110604629
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110604597
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110604637
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110604704
[Test build #34564 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34564/consoleFull)
for PR 6735 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32162020
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1804,15 +1804,10 @@ private[spark] object Utils extends Logging {
lazy
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6735
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32163888
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1804,15 +1804,10 @@ private[spark] object Utils extends Logging {
lazy val
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32163634
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1804,15 +1804,10 @@ private[spark] object Utils extends Logging {
lazy
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110877149
LGTM. All of my comments are documentation related. I will fix these on
merge myself.
This is going into master.
---
If your project is set up for it, you
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32152248
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1804,15 +1804,10 @@ private[spark] object Utils extends Logging {
lazy
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32152268
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1804,15 +1804,10 @@ private[spark] object Utils extends Logging {
lazy
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32154105
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1804,15 +1804,10 @@ private[spark] object Utils extends Logging {
lazy val
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32151885
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -109,7 +109,14 @@ private[spark] object ClosureCleaner extends Logging {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32152050
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -109,7 +109,14 @@ private[spark] object ClosureCleaner extends Logging {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32153072
--- Diff:
core/src/test/scala/org/apache/spark/util/ClosureCleanerSuite.scala ---
@@ -350,3 +354,40 @@ private object TestUserClosuresActuallyCleaned {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110788559
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110792620
[Test build #34594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34594/console)
for PR 6735 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110792643
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110569154
/cc @andrewor14 @srowen @preeze
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/6735
[SPARK-7527][Core]Fix createNullValue to return the correct null values and
REPL mode detection
The root cause of SPARK-7527 is `createNullValue` returns an incompatible
value `Byte(0) for `char`
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110569484
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110569493
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110570021
[Test build #34557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34557/consoleFull)
for PR 6735 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110583416
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6735#issuecomment-110583405
[Test build #34557 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34557/console)
for PR 6735 at commit
40 matches
Mail list logo