Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60557917
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60562034
[Test build #473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/473/consoleFull)
for PR 2884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60562729
[Test build #473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/473/consoleFull)
for PR 2884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60638639
[Test build #475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/475/consoleFull)
for PR 2884 at commit
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60638579
retest this again, seems Jenkins get something wrong and failed in
```JoinSuite```. locally it passed.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60642123
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/477/consoleFull)
for PR 2884 at commit
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60650011
```CliSuite``` failed due to Futures timed out, @liancheng any idea about
this? seems https://github.com/apache/spark/pull/2823/files does not fix the
problem.
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60654462
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/477/consoleFull)
for PR 2884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60654664
[Test build #475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/475/consoleFull)
for PR 2884 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60706370
Minor comment: In the future please put SPARK- in all capitals in the
title so that our merge scripts recognize it. Thanks!
Thanks for working on this!
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60536387
Great, thanks for finding this and adding a test. Regarding the
implementation, I'd like to try to avoid doing too much string munging as its
generally easy to forget
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60544840
Cool, i think this is better
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60475551
Added a test case for lower case issue, the test will throw NPE if not
converted to lowercase
---
If your project is set up for it, you can reply to this email and have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2884#discussion_r19354518
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -81,7 +81,8 @@ case class HiveTableScan(
//
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/2884#discussion_r19362161
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -81,7 +81,8 @@ case class HiveTableScan(
// Specifies
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60198477
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/411/consoleFull)
for PR 2884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60198722
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/411/consoleFull)
for PR 2884 at commit
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60201488
test failed due to streaming compile error, can you retest this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60209325
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/412/consoleFull)
for PR 2884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60209693
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/412/consoleFull)
for PR 2884 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60216081
Hm, the failure was caused by a known Jenkins configuration issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60324639
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60325180
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22096/consoleFull)
for PR 2884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60329177
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22096/consoleFull)
for PR 2884 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60329180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2884#discussion_r19197580
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -81,7 +81,8 @@ case class HiveTableScan(
//
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60050626
@yhuai, it's hard to make a unit test for this since
```addColumnMetadataToConf``` and ```hiveExtraConf``` both can not accessed in
test case, they are private. Actually i
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60052699
I think this change is generally a safe. LGTM, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/2884
[Spark-4041][SQL]attributes names in table scan should converted to
lowercase when compare with relation attributes
In ```MetastoreRelation``` the attributes name is lowercase because of hive
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-6985
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60013954
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60025997
Can you add a unit test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
33 matches
Mail list logo
