Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1188#discussion_r15331036
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -99,19 +99,30 @@ private[ui] class StageTableBase(
{s.name}
Github user nevillelyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/1188#discussion_r15331106
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -99,19 +99,30 @@ private[ui] class StageTableBase(
{s.name}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1188#discussion_r15332185
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -99,19 +99,30 @@ private[ui] class StageTableBase(
{s.name}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1188#discussion_r15332227
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -99,19 +99,30 @@ private[ui] class StageTableBase(
{s.name}
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49973457
Built and tested it locally. I was actually proposing pulling the Persisted
RDD part outside of the toggle component. I think it's fine either way, but if
we decide to
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49973700
One more thing - after playing in my browser I think just saying RDD: XX
is sufficient. Not sure Persistent adds much, and it will save space. Still
prefer it non-bold.
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-50029491
Addressed most of the comments. I kept it inside the box to avoid clutter
in case name gets too long. Also renamed link to +details
---
If your project is set up for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-50029551
QA tests have started for PR 1188. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17120/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-50035532
QA results for PR 1188:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1188#discussion_r15366746
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -99,19 +100,30 @@ private[ui] class StageTableBase(
{s.name}
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-50079022
Okay I tested locally - this is cool! Merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49967529
Sorry I should have said this earlier, but given that there can be only one
cached RDD per stage, what about just saying Persisted RDD: XX? Having a drop
down isn't
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49967711
XX is rddInfo.name and can be pretty long though if the user decide to
setName on an RDD. Also in an early PR we set name to input path for RDDs
opened directly from
Github user nevillelyh closed the pull request at:
https://github.com/apache/spark/pull/1188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user nevillelyh reopened a pull request:
https://github.com/apache/spark/pull/1188
SPARK-2250: show stage RDDs in UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nevillelyh/spark neville/ui
Alternatively you can
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49967797
Sounds good, I'll revert back to show details and include RDD in drop
down.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49967972
@nevillelyh I like show call stack actually (it's more accurate). So fine
if you keep that. Or maybe it could even just say call stack. Anyways fine
either way.
---
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49786260
Hi @nevillelyh, this seems a little too much information, and the use cases
aren't immediately clear to me. If we show only persisted RDDs, however, that
might be
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49786272
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49786568
@andrewor14 it's useful in apps with many iterations, i.e. ALS. I can
filter out RDDs with (default) numeric names or 0 cached partitions if that
make more sense?
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49787037
QA tests have started for PR 1188. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16982/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49800030
QA results for PR 1188:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49809162
@nevillelyh As a first step it would be interesting to see a version that
only includes persisted RDD's. In that case the RDD name could link to the
relevant page in
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49820124
I revised it so that the +show RDDs link is shown only when there are
cached RDDs (with links). Hope this is more useful.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49820213
QA tests have started for PR 1188. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17000/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49825981
QA results for PR 1188:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49698747
@andrewor14 ping again?
Rebased again and scalastyle/tests passed locally.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49220170
QA tests have started for PR 1188. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16744/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49220283
QA results for PR 1188:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49220820
Sorry missed one. Fixed the style warning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49114917
@andrewor14 ping
rebased again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49117535
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49117678
QA tests have started for PR 1188. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16700/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49117708
QA results for PR 1188:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-49118200
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-47612045
@andrewor14 I resolved merge conflicts and posted screenshot above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-47230100
Screenshot for the proposed change:
---
If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-47158324
Hey @nevillelyh, can you attach a screenshot or two?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user nevillelyh opened a pull request:
https://github.com/apache/spark/pull/1188
SPARK-2250: show stage RDDs in UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nevillelyh/spark neville/ui
Alternatively you can review
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1188#issuecomment-46926761
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
41 matches
Mail list logo
