[GitHub] spark pull request: system function upper and lower can be support...

2014-06-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44889196 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44889575 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44889665 Change the PR title to begin with [SPARK-1995][SQL] ... please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44889602 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44897649 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44897650 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15355/ --- If your project

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread egraldlo
GitHub user egraldlo opened a pull request: https://github.com/apache/spark/pull/936 system function upper and lower can be supported I don't know whether it's time to implement system function about string operation in spark sql now. You can merge this pull request into a Git

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44780014 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13270261 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -115,3 +131,21 @@ case class RLike(left:

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13270263 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -115,3 +131,21 @@ case class RLike(left:

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13270260 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -70,6 +70,22 @@ trait StringRegexExpression {

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13270266 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -115,3 +131,21 @@ case class RLike(left:

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44798014 LGTM except some minor formatting issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13270287 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -115,3 +131,21 @@ case class RLike(left:

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13270290 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -115,3 +131,21 @@ case class RLike(left:

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44800060 Thanks for doing this! We should add this to [the hive

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13271121 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -115,3 +131,21 @@ case class RLike(left:

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13271128 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -70,6 +70,22 @@ trait StringRegexExpression {

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/936#discussion_r13271167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -115,3 +131,21 @@ case class RLike(left:

[GitHub] spark pull request: system function upper and lower can be support...

2014-06-01 Thread egraldlo
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44802398 thanks @liancheng and @marmbrus, I have modified the formatting issues and nullable. --- If your project is set up for it, you can reply to this email and have your