[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74542387 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala --- @@ -174,6 +174,18 @@ class JDBCWriteSuite extends SharedSQLContext

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74550111 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -423,6 +423,10 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74542181 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala --- @@ -20,14 +20,21 @@ package

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74550467 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -423,6 +423,10 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74546716 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -423,6 +423,10 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74546013 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -423,6 +423,10 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74542628 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala --- @@ -20,14 +20,21 @@ package

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74278231 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74207701 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74207520 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74192910 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74192492 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74188842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74187289 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74178124 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74177938 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74029250 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74028772 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74028584 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74027679 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74027475 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74026903 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74015718 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74015696 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

GitHub user GraceH opened a pull request: https://github.com/apache/spark/pull/14559 [SPARK-16968]Add additional options in jdbc when creating a new table ## What changes were proposed in this pull request? In the PR, we just allow the user to add additional options when