[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77321926 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -374,15 +374,17 @@ setQuantifier ;

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77321974 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -364,6 +364,15 @@ class PlanParserSuite extends

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77321274 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -364,6 +364,15 @@ class PlanParserSuite extends

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77320991 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -364,6 +364,15 @@ class PlanParserSuite extends

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77320471 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -374,15 +374,17 @@ setQuantifier ;

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-08-29 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/14867 [SPARK-17296][SQL] Simplify join parser join processing. ## What changes were proposed in this pull request? Join processing in the parser relies on the fact that the grammar produces a