Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15874
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89215405
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,38 @@ import org.apache.spark.sql.types.StructType
/**
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89215190
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -112,25 +116,26 @@ class MinHash(override val uid: String) extends
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89215142
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala ---
@@ -97,12 +118,31 @@ class MinHashSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89180705
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,38 @@ import org.apache.spark.sql.types.StructType
/**
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89175604
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
---
@@ -43,70 +43,73 @@ class RandomProjectionSuite
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89175438
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -155,8 +148,30 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
}
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89175473
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -155,8 +148,30 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
}
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89175497
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,38 @@ import org.apache.spark.sql.types.StructType
/**
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89175448
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -155,8 +148,30 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
}
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89175401
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,38 @@ import org.apache.spark.sql.types.StructType
/**
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89015981
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,38 @@ import org.apache.spark.sql.types.StructType
/**
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89015678
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,38 @@ import org.apache.spark.sql.types.StructType
/**
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89013164
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -155,8 +148,30 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
}
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89013407
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -155,8 +148,30 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
}
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89021397
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala ---
@@ -97,12 +118,31 @@ class MinHashSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89015206
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,38 @@ import org.apache.spark.sql.types.StructType
/**
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89017969
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -112,25 +116,26 @@ class MinHash(override val uid: String) extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89020384
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
---
@@ -43,70 +43,73 @@ class RandomProjectionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89013284
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -155,8 +148,30 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
}
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88753014
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,40 @@ import org.apache.spark.sql.types.StructType
/**
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88569303
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
---
@@ -43,70 +43,72 @@ class RandomProjectionSuite
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88569315
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
---
@@ -115,64 +117,83 @@ class RandomProjectionSuite
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88569321
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala ---
@@ -86,9 +94,24 @@ class MinHashSuite extends SparkFunSuite with
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88569056
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSH.scala
---
@@ -147,15 +151,17 @@ class RandomProjection(override val
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88569084
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,34 @@ import org.apache.spark.sql.types.StructType
/**
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88569066
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,34 @@ import org.apache.spark.sql.types.StructType
/**
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88536087
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -179,16 +211,13 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88351861
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,34 @@ import org.apache.spark.sql.types.StructType
/**
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88359545
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
---
@@ -115,64 +117,83 @@ class RandomProjectionSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88349223
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSH.scala
---
@@ -147,15 +151,17 @@ class RandomProjection(override
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88353870
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -92,18 +93,17 @@ class MinHashModel private[ml] (
* LSH class for
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88359067
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
---
@@ -43,70 +43,72 @@ class RandomProjectionSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88351984
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,36 +31,34 @@ import org.apache.spark.sql.types.StructType
/**
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88521575
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala ---
@@ -86,9 +94,24 @@ class MinHashSuite extends SparkFunSuite with
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88169546
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -179,16 +211,13 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88150618
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -179,16 +211,13 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88142430
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -179,16 +211,13 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88129780
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala ---
@@ -24,7 +24,7 @@ import org.apache.spark.ml.util.DefaultReadWriteTest
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88129663
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -179,16 +211,13 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88129409
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -106,22 +123,24 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
*
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128756
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -144,12 +152,12 @@ class MinHash(override val uid: String) extends
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128823
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -66,10 +66,10 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
self:
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128732
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -125,11 +125,11 @@ class MinHash(override val uid: String) extends
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128687
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -74,9 +72,12 @@ class MinHashModel private[ml] (
}
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128341
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -74,9 +72,12 @@ class MinHashModel private[ml] (
}
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128287
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -46,21 +42,23 @@ import org.apache.spark.sql.types.StructType
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128199
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -31,13 +31,9 @@ import org.apache.spark.sql.types.StructType
/**
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r88128252
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -46,21 +42,23 @@ import org.apache.spark.sql.types.StructType
49 matches
Mail list logo
