[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91765482 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -115,7 +115,8 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91670157 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -115,7 +115,8 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91654619 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -115,7 +115,8 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91654375 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -115,7 +115,8 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91541946 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -115,7 +115,8 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91352281 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -1110,6 +1110,17 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91345742 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -1110,6 +1110,16 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91329867 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -1110,6 +1110,16 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16175#discussion_r91219886 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -1110,6 +1110,14 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #16175: [SPARK-17460][SQL]check if statistics.sizeInBytes...

GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/16175 [SPARK-17460][SQL]check if statistics.sizeInBytes >=0 in canBroadcast ## What changes were proposed in this pull request? 1. In SparkStrategies.canBroadcast, I will add the check