[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-07 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131713763 --- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala --- @@ -92,6 +92,31 @@ class DiskStoreSuite extends SparkFunSuite {

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-07 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131712834 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -165,6 +147,62 @@ private[spark] class DiskStore( }

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131709108 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -165,6 +147,62 @@ private[spark] class DiskStore( }

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131549141 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -165,6 +147,62 @@ private[spark] class DiskStore( }

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131544351 --- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala --- @@ -92,6 +92,31 @@ class DiskStoreSuite extends SparkFunSuite {

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131544332 --- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala --- @@ -92,6 +92,31 @@ class DiskStoreSuite extends SparkFunSuite {

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131544320 --- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala --- @@ -92,6 +92,31 @@ class DiskStoreSuite extends SparkFunSuite {

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131543591 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -165,6 +147,62 @@ private[spark] class DiskStore( }

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131543602 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -165,6 +147,62 @@ private[spark] class DiskStore( }

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131543345 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -165,6 +147,62 @@ private[spark] class DiskStore( }

[GitHub] spark pull request #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fa...

2017-08-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131543084 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -165,6 +147,62 @@ private[spark] class DiskStore( }

[GitHub] spark pull request #18855: [Spark 3151][Block Manager] DiskStore.getBytes fa...

2017-08-05 Thread eyalfa
GitHub user eyalfa opened a pull request: https://github.com/apache/spark/pull/18855 [Spark 3151][Block Manager] DiskStore.getBytes fails for files larger than 2GB ## What changes were proposed in this pull request? introduced `DiskBlockData`, a new implementation of