Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18935
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r134052216
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/NettyMemoryMetrics.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r134051537
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
---
@@ -106,6 +105,12 @@ public
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r134050644
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/NettyMemoryMetrics.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r133874147
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -61,6 +62,7 @@ public TransportConf(String module,
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r133873922
--- Diff: pom.xml ---
@@ -571,7 +571,7 @@
io.netty
netty-all
-4.0.43.Final
+4.0.47.Final
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r133013594
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/util/NettyMemoryMetricsSuite.java
---
@@ -0,0 +1,115 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r133013174
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
---
@@ -57,7 +55,7 @@
*
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/18935
[SPARK-9104][CORE] Expose Netty memory metrics in Spark
## What changes were proposed in this pull request?
This PR exposes Netty memory usage for Spark's `TransportClientFactory` and
