[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-09-11 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r138114144 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -443,7 +444,8 @@ case class

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-09-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r138095165 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -443,7 +444,8 @@ case class Range(

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18973 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134596298 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala --- @@ -451,6 +451,17 @@ class StreamingQuerySuite extends

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134595799 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala --- @@ -451,6 +451,17 @@ class StreamingQuerySuite extends

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134367553 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -118,8 +122,15 @@ case class MemoryStream[A :

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134367543 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -420,8 +420,10 @@ class SQLContext private[sql](val sparkSession:

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134367548 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -728,7 +729,16 @@ class FakeDefaultSource extends

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134347764 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -420,8 +420,10 @@ class SQLContext private[sql](val sparkSession: SparkSession)

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134345519 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -728,7 +729,16 @@ class FakeDefaultSource extends FakeSource {

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134345291 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -728,7 +729,16 @@ class FakeDefaultSource extends FakeSource {

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134345008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -118,8 +122,15 @@ case class MemoryStream[A : Encoder](id:

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134344753 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -118,8 +122,15 @@ case class MemoryStream[A : Encoder](id:

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-21 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r134334867 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala --- @@ -43,7 +43,9 @@ object LocalRelation { }

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-17 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r133844686 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala --- @@ -43,7 +43,9 @@ object LocalRelation {

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-17 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r133844671 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -564,10 +564,14 @@ class SparkSession private( */

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-17 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r133844681 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala --- @@ -75,7 +75,7 @@ class LogicalPlanSuite

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r133815427 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -564,10 +564,14 @@ class SparkSession private( */ private[sql]

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r133813571 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala --- @@ -75,7 +75,7 @@ class LogicalPlanSuite extends

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/18973#discussion_r133812777 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala --- @@ -43,7 +43,9 @@ object LocalRelation { }

[GitHub] spark pull request #18973: [SPARK-21765] Set isStreaming on leaf nodes for s...

2017-08-17 Thread joseph-torres
GitHub user joseph-torres opened a pull request: https://github.com/apache/spark/pull/18973 [SPARK-21765] Set isStreaming on leaf nodes for streaming plans. ## What changes were proposed in this pull request? All logically streaming plans will now have is. This involved adding