Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140968754
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140936872
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140935586
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140933568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,46 @@ object
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140933095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -157,11 +164,20 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140931385
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,46 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140914684
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -309,19 +396,24 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140912351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140906369
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -324,17 +389,33 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140927997
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -416,32 +421,32 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140905683
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140910541
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140903737
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140900883
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -157,11 +164,20 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140910588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140911830
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140913768
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140911442
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140904307
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140913094
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140928059
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -146,7 +146,14 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140912029
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140911245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -87,70 +87,157 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140900266
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -157,11 +164,20 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140903616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +232,70 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140910781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -324,17 +389,33 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140605142
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -146,7 +146,13 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140608418
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140615004
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140616618
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +229,51 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140614146
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140605854
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -324,17 +367,34 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140617927
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +229,51 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140614325
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140608463
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140612077
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -329,6 +392,27 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140607924
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140611178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -329,6 +392,27 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140612202
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140605588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -324,17 +367,34 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140614816
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140617841
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -216,22 +229,51 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140606013
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140615574
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -116,6 +116,26 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140608032
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140614563
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140614721
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -89,61 +89,124 @@ class
GitHub user joseph-torres opened a pull request:
https://github.com/apache/spark/pull/19327
[WIP] Implement stream-stream outer joins.
## What changes were proposed in this pull request?
Allow one-sided outer joins between two streams when a watermark is defined.
48 matches
Mail list logo
