Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19926
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r157047178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
---
@@ -0,0 +1,407 @@
+/*
+ * Licensed
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r157044691
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
---
@@ -0,0 +1,407 @@
+/*
+ * Licensed to the
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r157041705
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -231,14 +201,14 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156532817
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -447,296 +384,6 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156532669
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
---
@@ -237,7 +237,7 @@ class StreamingQueryManager
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156527867
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -71,27 +68,29 @@ class StreamExecution(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156527709
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -447,296 +384,6 @@ class StreamExecution(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156527409
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
---
@@ -237,7 +237,7 @@ class StreamingQueryManager
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156471697
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
---
@@ -237,7 +237,7 @@ class StreamingQueryManager
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156471355
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -783,29 +430,29 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156470973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -447,296 +384,6 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156468624
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -71,27 +68,29 @@ class StreamExecution(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156458057
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
---
@@ -237,7 +237,7 @@ class StreamingQueryManager
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156451593
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -71,27 +68,29 @@ class StreamExecution(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156461586
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -447,296 +384,6 @@ class StreamExecution(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156451756
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -71,27 +68,29 @@ class StreamExecution(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156457754
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -783,29 +430,29 @@ class StreamExecution(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156458765
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala ---
@@ -285,12 +285,13 @@ trait StreamTest extends QueryTest with
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156459771
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -71,27 +68,29 @@ class StreamExecution(
GitHub user joseph-torres opened a pull request:
https://github.com/apache/spark/pull/19926
[SPARK-22733] Split StreamExecution into MicroBatchExecution and
StreamExecution.
## What changes were proposed in this pull request?
StreamExecution is now an abstract base class,
21 matches
Mail list logo
