Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20925
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r180193625
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -154,9 +165,17 @@
List buildSparkSubmitArgs()
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r180193382
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -775,17 +781,17 @@ class SparkSubmitSuite
}
test("SPA
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179987224
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -154,9 +165,17 @@
List buildSparkSubmitArgs()
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179987409
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -154,9 +165,17 @@
List buildSparkSubmitArgs()
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179952361
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -775,17 +781,17 @@ class SparkSubmitSuite
}
test("SPA
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179892764
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -99,17 +100,27 @@
*/
private boolean allowsM
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179892170
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -88,7 +88,8 @@
SparkLauncher.NO_RESOURCE);
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179892080
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -499,20 +497,18 @@ private[deploy] class SparkSubmitArguments(args:
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179816905
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -499,20 +497,18 @@ private[deploy] class SparkSubmitArguments(ar
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179814761
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -289,27 +288,26 @@ private[deploy] class SparkSubmitArguments(ar
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179832847
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -99,17 +100,27 @@
*/
private boolean al
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179825806
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -88,7 +88,8 @@
SparkLauncher.NO_RESOURCE);
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179834098
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -400,6 +419,11 @@ private boolean isThriftServer(Strin
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/20925
[SPARK-22941][core] Do not exit JVM when submit fails with in-process
launcher.
The current in-process launcher implementation just calls the SparkSubmit
object, which, in case of errors, will m
15 matches
Mail list logo
