Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21356
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189702478
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -130,7 +129,11 @@ private class AsyncEventQueue(val name: String, conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189695936
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -130,7 +129,11 @@ private class AsyncEventQueue(val name: String, conf:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189675372
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,7 +89,16 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logg
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189647689
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,7 +89,16 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189607562
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -111,6 +111,12 @@ private[spark] class LiveListenerBus(conf: SparkCo
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189604443
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,7 +89,16 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189516219
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,7 +89,16 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logg
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189483397
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,6 +89,11 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logging
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189384006
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,6 +89,11 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189350251
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,6 +89,11 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189349209
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -111,6 +111,12 @@ private[spark] class LiveListenerBus(conf: SparkConf)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189349081
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -187,6 +190,12 @@ private class AsyncEventQueue(val name: String, conf:
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189152423
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -97,6 +98,11 @@ private class AsyncEventQueue(val name: String, conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189099861
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -34,7 +34,8 @@ import org.apache.spark.util.Utils
* Delivery will
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189100750
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -97,6 +98,11 @@ private class AsyncEventQueue(val name: String, conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189100255
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
@@ -489,6 +489,38 @@ class SparkListenerSuite extends SparkFunSuite wit
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/21356
[SPARK-24309][CORE] AsyncEventQueue should stop on interrupt.
EventListeners can interrupt the event queue thread. In particular,
when the EventLoggingListener writes to hdfs, hdfs can interrupt
18 matches
Mail list logo
