[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211802430 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/TemplateVolumeStep.scala --- @@ -0,0 +1,51 @@ +/*

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211800379 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -96,3 +112,25 @@

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211800127 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/TemplateVolumeStep.scala --- @@ -0,0 +1,51 @@ +/*

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211800821 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -51,7 +57,13 @@

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211799242 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala --- @@ -59,5 +65,23 @@ private[spark] object

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211801962 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/TemplateVolumeStep.scala --- @@ -0,0 +1,51 @@ +/*

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211800415 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -16,11 +16,17 @@

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211800326 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -96,3 +112,25 @@

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-21 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r211800176 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/TemplateVolumeStep.scala --- @@ -0,0 +1,51 @@ +/*

[GitHub] spark pull request #22146: [WIP][SPARK-24434][K8S] pod template files

2018-08-19 Thread onursatici
GitHub user onursatici opened a pull request: https://github.com/apache/spark/pull/22146 [WIP][SPARK-24434][K8S] pod template files ## What changes were proposed in this pull request? New feature to pass podspec files for driver and executor pods. ## How was this