[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218814303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -40,10 +40,13 @@ import

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218808837 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -40,10 +40,13 @@ import

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218765559 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218762046 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218761031 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218760543 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218758428 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218754608 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218690339 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -83,4 +83,7 @@ select

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218690147 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -83,4 +83,7 @@ select

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218689456 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -83,4 +83,7 @@ select

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218688998 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -83,4 +83,7 @@ select

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-18 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22450 [SPARK-25454][SQL] Avoid precision loss in division with decimal with negative scale ## What changes were proposed in this pull request? Our rules for determine decimal precision and