cloud-fan commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2082859873
reducing cardinality SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
yaooqinn commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2082071977
Hey guys,
I am currently regenerating the complete benchmark result with 20 jobs
running simultaneously. Each job usually takes around 10 to 30 minutes to
complete. However, the
stefankandic commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2030162287
@dbatomic which ones are 100x? Biggest differences I'm seeing in the
benchmark numbers are around 10x
--
This is an automated message from the Apache Git Service.
To respond to
dbatomic commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2030064654
Thanks @GideonPotok . Btw, we are also working on tightening perf so these
100x should soon move to 2-3x :).
--
This is an automated message from the Apache Git Service.
To respond to
dongjoon-hyun commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2029972677
Thank you for adding this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cloud-fan closed pull request #45453: [SPARK-46840][SQL][TESTS] Add
`CollationBenchmark`
URL: https://github.com/apache/spark/pull/45453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cloud-fan commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2029846119
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
GideonPotok commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2029759042
@cloud-fan @dbatomic @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
GideonPotok commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2027383540
@MaxGekk or @cloud-fan can you merge this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
GideonPotok commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2025233876
@MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1541440974
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
cloud-fan commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1541221151
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1541176949
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1541127406
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
cloud-fan commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1540259864
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1540048010
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1540047223
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1539418002
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
cloud-fan commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1539342857
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1539275734
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538210182
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1539275734
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1539275734
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
cloud-fan commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538466180
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538211202
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538210182
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538204774
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538204774
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538163900
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
MaxGekk commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538045707
##
sql/core/benchmarks/CollationBenchmark-results.txt:
##
@@ -0,0 +1,26 @@
+OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1016-azure
+AMD EPYC 7763 64-Core
GideonPotok commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2018610421
@MaxGekk / @cloud-fan - made suggested changes. Can you do another round of
review on your side and merge if everything looks fine?
--
This is an automated message from the Apache
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1538037516
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537987211
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537987211
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537987211
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537987211
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
GideonPotok commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537987211
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
cloud-fan commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537858501
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation
cloud-fan commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537855722
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation
cloud-fan commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537852758
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation
MaxGekk commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537399607
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation
dbatomic commented on PR #45453:
URL: https://github.com/apache/spark/pull/45453#issuecomment-2017715401
LGTM (+one minor comment).
@MaxGekk / @cloud-fan - can you do review on your side and merge if
everything looks fine?
--
This is an automated message from the Apache Git
dbatomic commented on code in PR #45453:
URL: https://github.com/apache/spark/pull/45453#discussion_r1537386952
##
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation
43 matches
Mail list logo
