Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-05-07 Thread via GitHub
AngersZh commented on PR #46263: URL: https://github.com/apache/spark/pull/46263#issuecomment-2097597566 > @AngersZh can you create a backport PR for 3.5? it has conflicts. https://issues.apache.org/jira/browse/SPARK-44649 bring this issue, only on branch-4.0, no need to

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-05-07 Thread via GitHub
cloud-fan commented on PR #46263: URL: https://github.com/apache/spark/pull/46263#issuecomment-2097570802 @AngersZh can you create a backport PR for 3.5? it has conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-05-07 Thread via GitHub
cloud-fan closed pull request #46263: [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type URL: https://github.com/apache/spark/pull/46263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-05-07 Thread via GitHub
cloud-fan commented on PR #46263: URL: https://github.com/apache/spark/pull/46263#issuecomment-2097568681 the last commit only changes code comment, merging to master/3.5, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-05-07 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1591889612 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -129,24 +129,43 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-05-06 Thread via GitHub
AngersZh commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1590728816 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -129,17 +136,36 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-05-06 Thread via GitHub
AngersZh commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1590623455 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -129,17 +136,36 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-29 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1584077334 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -129,17 +136,36 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-29 Thread via GitHub
AngersZh commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582618679 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,33 +132,61 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-29 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582597230 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,33 +132,61 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-29 Thread via GitHub
AngersZh commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582589876 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-29 Thread via GitHub
AngersZh commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582582142 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582495818 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582492374 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582495367 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582495367 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
cloud-fan commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582492374 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
beliefer commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582090760 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -86,6 +87,17 @@ object InjectRuntimeFilter extends

Re: [PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
beliefer commented on code in PR #46263: URL: https://github.com/apache/spark/pull/46263#discussion_r1582095704 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -120,34 +132,49 @@ object InjectRuntimeFilter extends

[PR] [SPARK-48027][SQL] InjectRuntimeFilter for multi-level join should check child join type [spark]

2024-04-28 Thread via GitHub
AngersZh opened a new pull request, #46263: URL: https://github.com/apache/spark/pull/46263 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was