Re: Review Request 45405: AMBARI-15610 Add Service Wizard: invalid host name doesn't prevent proceeding to next page

2016-03-29 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45405/#review125893 --- Ship it! Ship It! - Alexandr Antonenko On March 28, 2016,

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review125890 ---

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125904 ---

Review Request 45432: App Timeline Web UI Warning Alert is always present after Disabling security a few times

2016-03-29 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45432/ --- Review request for Ambari, Andrew Onischuk and Jonathan Hurley. Bugs:

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 29, 2016, 4:06 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125898 ---

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-29 Thread Juanjo Marron
> On March 28, 2016, 6:28 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py, > > line 22 > > > > > > Can we remove

Re: Review Request 45432: App Timeline Web UI Warning Alert is always present after Disabling security a few times

2016-03-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45432/#review125901 --- Ship it! Ship It! - Jonathan Hurley On March 29, 2016,

Re: Review Request 45432: App Timeline Web UI Warning Alert is always present after Disabling security a few times

2016-03-29 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45432/#review125906 ---

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45054/ --- (Updated March 29, 2016, 5:03 p.m.) Review request for Ambari, Alejandro

Re: Review Request 45405: AMBARI-15610 Add Service Wizard: invalid host name doesn't prevent proceeding to next page

2016-03-29 Thread Alexandr Antonenko
> On March 29, 2016, 4:16 p.m., Alexandr Antonenko wrote: > > Ship It! Tested manually, good UX improvement. - Alexandr --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45405/#review125893

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
> On March 29, 2016, 4:17 p.m., Jayush Luniya wrote: > > Ship It! @Juanjo Please see my comments below. I noticed the issue after I +1'ed. Can you revise the patch? - Jayush --- This is an automatically generated e-mail. To reply,

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45338/#review125908 ---

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-29 Thread Di Li
> On March 18, 2016, 10:07 p.m., Alejandro Fernandez wrote: > > Thank you for adding this. Any unit tests? yes, unit tests for both UI and java backend. I also added more unit tests to the latest patch. - Di --- This is an

Review Request 45442: Orphaned Host Alerts Cause Stale Alert Notifications After Removing Hosts

2016-03-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45442/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate

Re: Review Request 45407: AMBARI-15114: Stack Featurize HBASE Service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45407/#review125913 --- Ship it! Ship It! - Jayush Luniya On March 28, 2016, 11:38

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Nahappan Somasundaram
> On March 29, 2016, 6:25 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java, > > line 59 > > > > > > updatable false? Yes. It is created

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/#review125933 ---

Re: Review Request 45442: Orphaned Host Alerts Cause Stale Alert Notifications After Removing Hosts

2016-03-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45442/#review125940 --- Ship it!

Review Request 45447: AMBARI-15621 : Cluster Second aggregator taking more than 2 mins to execute on large clusters, thereby causing lag.

2016-03-29 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45447/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable

2016-03-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45413/#review125916 ---

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Ajit Kumar
> On March 29, 2016, 1:25 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java, > > lines 116-119 > > > > > > I understand that blueprint

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/ --- (Updated March 29, 2016, 11:44 a.m.) Review request for Ambari, Ajit Kumar,

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Jonathan Hurley
> On March 29, 2016, 9:25 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java, > > lines 32-38 > > > > > > These can be unique, but don't

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Jonathan Hurley
> On March 29, 2016, 9:14 a.m., Jonathan Hurley wrote: > > Was this committed? If so, can we close the review? Whoops; wrong review; disregard. - Jonathan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable

2016-03-29 Thread Richard Zang
> On March 29, 2016, 5:39 p.m., Alejandro Fernandez wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 85 > > > > > > Why is the UI tracking this and not the stack? We are

Review Request 45459: AMBARI-15622. 'phoenix.query.spoolThresholdBytes' property doesn't have a description on UI

2016-03-29 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45459/ --- Review request for Ambari and Sid Wagle. Bugs: AMBARI-15622

Re: Review Request 45442: Orphaned Host Alerts Cause Stale Alert Notifications After Removing Hosts

2016-03-29 Thread Jonathan Hurley
> On March 29, 2016, 3:46 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java, > > lines 404-405 > > > > > > Would anyone need any

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/#review125986 --- Fix it, then Ship it!

Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance Values Exposed In Web Client

2016-03-29 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45462/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley,

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/ --- (Updated March 29, 2016, 4:34 p.m.) Review request for Ambari, Ajit Kumar,

Review Request 45460: AMBARI-15582: Stack Featurize Sqoop Service

2016-03-29 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45460/ --- Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs:

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/#review125872 ---

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-03-29 Thread Tim Thorpe
> On March 29, 2016, 12:49 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java, > > lines 535-547 > > > > > > What exactly is the use case for marshalling back

Re: Review Request 45407: AMBARI-15114: Stack Featurize HBASE Service

2016-03-29 Thread Jayush Luniya
> On March 29, 2016, 5:27 p.m., Jayush Luniya wrote: > > Ship It! commit 954a7072b0d3d82e5f818794b0a192a743b9c76a Author: Jayush Luniya Date: Tue Mar 29 19:02:06 2016 -0700 AMBARI-15114: Stack Featurize HBASE Service (Juanjo Marron via jluniya) - Jayush

Review Request 45465: Support distributed aggregation for multiple AMS instances

2016-03-29 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45465/ --- Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45458/ --- (Updated March 30, 2016, 1:34 a.m.) Review request for Ambari, Alejandro

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review126003 --- Ship it! Ship It! - Jayush Luniya On March 29, 2016, 8:06

Review Request 45374: Use ">>" instead of ">" to write ambari-metrics-collector.out

2016-03-29 Thread Akira Ajisaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45374/ --- Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle. Bugs:

Re: Review Request 45460: AMBARI-15582: Stack Featurize Sqoop Service

2016-03-29 Thread Jayush Luniya
> On March 30, 2016, 2:06 a.m., Jayush Luniya wrote: > > Ship It! commit a189c91b027f4949f0100820b2f1c96d90b38fce Author: Jayush Luniya Date: Tue Mar 29 19:06:33 2016 -0700 AMBARI-15582: Stack Featurize Sqoop Service (Juanjo Marron via jluniya) - Jayush

Re: Review Request 45460: AMBARI-15582: Stack Featurize Sqoop Service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45460/#review126009 --- Ship it! Ship It! - Jayush Luniya On March 29, 2016, 11:44

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45470/ --- (Updated March 30, 2016, 5:11 a.m.) Review request for Ambari, Alejandro

Re: Review Request 44724: AMBARI-12906: Alert notifications are created even if credential fields are left empty

2016-03-29 Thread Alexandr Antonenko
> On March 29, 2016, 1:13 p.m., Jonathan Hurley wrote: > > Was this committed? If so, can we close the review? Yes this was committed. We can close this review. - Alexandr --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-29 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/ --- (Updated March 29, 2016, 7:17 p.m.) Review request for Ambari, Ajit Kumar,

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45338/#review126012 --- Ship it! Ship It! - Jayush Luniya On March 29, 2016, 8:29

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45458/ --- (Updated March 30, 2016, 4:06 a.m.) Review request for Ambari, Alejandro