Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Gaurav Nagar
> On May 6, 2016, 2:12 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

2016-05-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47023/#review132081 --- ambari-server/pom.xml (lines 1371 - 1375)

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/#review132026 --- Fix it, then Ship it!

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-06 Thread Jonathan Hurley
> On May 6, 2016, 10:38 a.m., Jonathan Hurley wrote: > > contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java, > > line 121 > > > > > > Why is this

Re: Review Request 47067: Separate number of shards and replication factor configurations for audit logs and service logs (logseach solr)

2016-05-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47067/#review132066 --- Ship it! Ship It! - Robert Nettleton On May 6, 2016, 2:59

Re: Review Request 47047: AMBARI-16282 Refactor the VDF installer code to handle multi-stack and multi-version scenario

2016-05-06 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47047/#review132073 --- Ship it! Ship It! - Jaimin Jetly On May 5, 2016, 11:34

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Jonathan Hurley
> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47018: [preview] Ambari Upgrade shouldn't automatically add stack configs

2016-05-06 Thread Jonathan Hurley
> On May 5, 2016, 1:20 p.m., Nate Cole wrote: > > It feels to me like we should not be touching the stack for this, but > > rather use the config-upgrade.xml or the upgrade pack to hold this > > information. Then you can have ADD/DELETE/SKIP isolated in it's own file. > > That logic could

Re: Review Request 47060: AMBARI-16285 Ranger Tagsync stack changes to sync tags from Atlas

2016-05-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47060/#review132031 --- These property renames - I don't see them being handled for

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/ --- (Updated Май 6, 2016, 4 п.п.) Review request for Ambari, Robert Levas, Sumit

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/#review132025 --- Ship it! Ship It! - Jonathan Hurley On May 6, 2016, 7:28

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/ --- (Updated Май 6, 2016, 3:16 п.п.) Review request for Ambari, Robert Levas,

Review Request 47067: Separate number of shards and replication factor configurations for audit logs and service logs (logseach solr)

2016-05-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47067/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/#review132037 --- Ship it! Ship It! - Nate Cole On May 6, 2016, 7:28 a.m.,

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/ --- (Updated Май 6, 2016, 3:13 п.п.) Review request for Ambari, Robert Levas,

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Gaurav Nagar
> On May 6, 2016, 2:12 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/#review132034 ---

Re: Review Request 47018: [preview] Ambari Upgrade shouldn't automatically add stack configs

2016-05-06 Thread Nate Cole
> On May 5, 2016, 1:20 p.m., Nate Cole wrote: > > It feels to me like we should not be touching the stack for this, but > > rather use the config-upgrade.xml or the upgrade pack to hold this > > information. Then you can have ADD/DELETE/SKIP isolated in it's own file. > > That logic could

Re: Review Request 47079: Disabling and enabling back HiveServer2 Interactive does not show Assign Master popup

2016-05-06 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47079/#review132112 --- Ship it! Ship It! - Zhe (Joe) Wang On May 6, 2016, 10:34

Re: Review Request 47079: Disabling and enabling back HiveServer2 Interactive does not show Assign Master popup

2016-05-06 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47079/#review132110 --- Ship it! Ship It! - Richard Zang On May 6, 2016, 10:34

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/#review132009 ---

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/ --- (Updated May 6, 2016, 7:28 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-06 Thread Robert Levas
> On May 5, 2016, 1:10 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, lines > > 1092-1096 > > > > > > This syntax is so painful. Anyway to clean this up? maybe INSERT

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/#review132015 --- Ship it! Ship It! - Robert Levas On May 6, 2016, 6:04 a.m.,

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/#review131999 --- Ship it! Ship It! - Sebastian Toader On May 5, 2016, 2:19

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-06 Thread Jayush Luniya
> On May 5, 2016, 10:52 p.m., Jayush Luniya wrote: > > Ship It! > > Matt wrote: > Jayush, shall I commit this or are you working on it? Committed to trunk - Jayush --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 47024: Ambari build sometime fails on hudson (Python test issue)

2016-05-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47024/#review132005 --- Ship it! Ship It! - Dmytro Sen On Май 5, 2016, 3:56 п.п.,

Re: Review Request 47024: Ambari build sometime fails on hudson (Python test issue)

2016-05-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47024/#review132004 --- Ship it! Ship It! - Dmitro Lisnichenko On May 5, 2016, 6:56

Review Request 47060: AMBARI-16285 Ranger Tagsync stack changes to sync tags from Atlas

2016-05-06 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47060/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley,

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/#review132021 ---

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/ --- (Updated Май 6, 2016, 12:07 п.п.) Review request for Ambari, Robert Levas,

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/#review132018 --- Ship it! Ship It! - Oliver Szabo On May 6, 2016, 12:07

Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47063/ --- Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi Brodetskyi.

Review Request 47086: Modifications in Hive Interactive configs should trigger only Hive Interactive restart.

2016-05-06 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47086/ --- Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. Bugs:

Review Request 47085: Ambari agent changes to push llap metrics to AMS

2016-05-06 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47085/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.

Review Request 47079: Disabling and enabling back HiveServer2 Interactive does not show Assign Master popup

2016-05-06 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47079/ --- Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.

Re: Review Request 47045: AMBARI-16281: Config files for hive interactive should be in both conf and conf.server folder

2016-05-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47045/#review132121 --- Ship it! Ship It! - Sumit Mohanty On May 5, 2016, 10:38

Re: Review Request 47085: Ambari agent changes to push llap metrics to AMS

2016-05-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47085/#review132120 --- Ship it! Ship It! - Sumit Mohanty On May 7, 2016, 1:34