Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

2016-07-28 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50554/ --- Review request for Ambari, Gaurav Nagar and Pallav Kulshreshtha. Bugs: AMBARI-1

Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

2016-07-28 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50554/#review143904 --- Ship it! Ship It! - Gaurav Nagar On July 28, 2016, 8:01 a.m.

Review Request 50558: AMBARI-17942 : Update config dependencies for Ranger KMS [for Delete service action]

2016-07-28 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50558/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, Jayu

Review Request 50561: Hive View Upload table does not support line feed and carriage return in field delimiter

2016-07-28 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50561/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 50561: Hive View Upload table does not support line feed and carriage return in field delimiter

2016-07-28 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50561/ --- (Updated July 28, 2016, 11:22 a.m.) Review request for Ambari, DIPAYAN BHOWMICK

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143919 --- Ship it! Ship It! - Dmitro Lisnichenko On July 28, 2016, 2:0

Re: Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

2016-07-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50299/#review143920 --- Ship it! Ship It! - Dmitro Lisnichenko On July 28, 2016, 9:3

Re: Review Request 50558: AMBARI-17942 : Update config dependencies for Ranger KMS [for Delete service action]

2016-07-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50558/#review143922 --- Ship it! Ship It! - Robert Levas On July 28, 2016, 5:56 a.m.

Re: Review Request 50526: NameNode High Availability Health Alert Issue

2016-07-28 Thread Jonathan Hurley
> On July 27, 2016, 3:37 p.m., Dmytro Grinenko wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py, > > line 209 > > > > > > Looks like now, alert re

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143925 --- Ship it! Ship It! - Di Li On July 27, 2016, 11:06 p.m., Alej

Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-28 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, N

Review Request 50567: Initial Upgrade Checks Can Fail With ConcurrentModificationException

2016-07-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50567/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143928 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Re: Review Request 50567: Initial Upgrade Checks Can Fail With ConcurrentModificationException

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50567/#review143930 --- Ship it! Ship It! - Nate Cole On July 28, 2016, 9:18 a.m., J

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Dmytro Grinenko
> On July 28, 2016, 1:20 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java, > > lines 240-244 > > > > > > I'm a little confused by this - clus

Re: Review Request 50505: Coverity Scan Security Vulnerability - Resource Leak defects

2016-07-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50505/#review143934 --- Ship it! Ship It! - Dmytro Sen On Июль 27, 2016, 2:52 п.п.,

Re: Review Request 50505: Coverity Scan Security Vulnerability - Resource Leak defects

2016-07-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50505/#review143936 --- Ship it! This looks good to me; however I might add a comment t

Re: Review Request 50567: Initial Upgrade Checks Can Fail With ConcurrentModificationException

2016-07-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50567/ --- (Updated July 28, 2016, 11:14 a.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143947 --- Ship it! Ship It! - Jonathan Hurley On July 27, 2016, 7:06 p

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Jonathan Hurley
> On July 28, 2016, 11:58 a.m., Jonathan Hurley wrote: > > Ship It! After other comments are resolved. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143947 -

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/#review143950 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 50532: [Preview] Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review143951 --- We are going to hold on this patch. Between this and https://rev

Re: Review Request 50532: [Preview] Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-28 Thread Jonathan Hurley
> On July 28, 2016, 12:29 p.m., Nate Cole wrote: > > We are going to hold on this patch. Between this and > > https://reviews.apache.org/r/50508/, we're adding more complexity too late > > in the stage. Instead, please pursue a custom java class that will do this > > work, and we'll do Appen

Re: Review Request 50532: [Preview] Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-28 Thread Nate Cole
> On July 28, 2016, 12:29 p.m., Nate Cole wrote: > > We are going to hold on this patch. Between this and > > https://reviews.apache.org/r/50508/, we're adding more complexity too late > > in the stage. Instead, please pursue a custom java class that will do this > > work, and we'll do Appen

Re: Review Request 50542: AMBARI-17936 Log search tab seems to be visible for all user roles

2016-07-28 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50542/#review143957 --- Ship it! Ship It! - Alexandr Antonenko On Июль 27, 2016, 11:

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143966 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Jonathan Hurley
> On July 28, 2016, 9:20 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SQOOP/configuration/sqoop-atlas-application.properties.xml, > > lines 30-36 > > > > > > Do you need the on-

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/ --- (Updated July 28, 2016, 5:52 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 50395: Create configuration flag to prevent changing of directory permissions

2016-07-28 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50395/#review143969 --- Ship it! Ship It! - Aravindan Vijayan On July 26, 2016, 7:49

Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/ --- Review request for Ambari, Dmytro Sen, Jonathan Hurley, Myroslav Papirkovskyy, N

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143971 --- Ship it! Ship It! - Robert Levas On July 28, 2016, 1:52 p.m.

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/ --- (Updated July 28, 2016, 6:24 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/#review143979 --- Ship it! Ship It! - Robert Nettleton On July 28, 2016, 6:09

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/#review143980 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143987 --- Ship it! Ship It! - Nate Cole On July 28, 2016, 2:24 p.m., A

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/#review143988 --- Ship it! Ship It! - Nate Cole On July 28, 2016, 2:09 p.m., R

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/#review143991 --- Ship it! Concur with Jonathan's comments, then Ship It - Nate

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/#review143990 --- ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-u

Re: Review Request 50567: Initial Upgrade Checks Can Fail With ConcurrentModificationException

2016-07-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50567/#review143996 --- Ship it! Ship It! - Robert Levas On July 28, 2016, 3:09 p.m.

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Robert Levas
> On July 28, 2016, 3:38 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/HostUtils.java, > > lines 44-46 > > > > > > Could you instead use Guava's `InternetDomainName.isVal

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-28 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/ --- (Updated July 28, 2016, 9:22 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-28 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/ --- (Updated July 28, 2016, 9:25 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-28 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/ --- (Updated July 28, 2016, 9:28 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 50547: AMBARI-17939: Validations are missing for HDFS properties recommended by HAWQ

2016-07-28 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50547/ --- (Updated July 28, 2016, 9:30 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 50547: AMBARI-17939: Validations are missing for HDFS properties recommended by HAWQ

2016-07-28 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50547/#review144027 --- Ship it! Ship It! - Matt On July 28, 2016, 2:30 p.m., Alexan

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-28 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/ --- (Updated July 28, 2016, 11:07 p.m.) Review request for Ambari, Alejandro Fernan

Review Request 50589: Fix the "Hive Metastore" password getting exposed in Hive2 client's hive-site.xml

2016-07-28 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50589/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-

Re: Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

2016-07-28 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50299/#review144044 --- Ship it! Ship It! - Swapan Shridhar On July 28, 2016, 6:38 a

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Jonathan Hurley
> On July 28, 2016, 3:38 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/HostUtils.java, > > lines 44-46 > > > > > > Could you instead use Guava's `InternetDomainName.isVal

Re: Review Request 50589: Fix the "Hive Metastore" password getting exposed in Hive2 client's hive-site.xml

2016-07-28 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50589/#review144050 --- Ship it! Ship It! - Sumit Mohanty On July 29, 2016, 12:28 a.

Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-07-28 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50594/ --- Review request for Ambari, Jayush Luniya and Sumit Mohanty. Bugs: AMBARI-17954

Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-28 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17955 https

Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

2016-07-28 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50554/#review144061 --- Ship it! Ship It! - Ashwin Rajeev On July 28, 2016, 11:37 a.