Re: Review Request 62427: Add service wizard stuck at step 8

2017-09-19 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62427/#review185766 --- Ship it! - Vivek Ratnavel Subramanian On Sept. 20, 2017,

Review Request 62427: Add service wizard stuck at step 8

2017-09-19 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62427/ --- Review request for Ambari, Ishan Bhatt, Vivek Ratnavel Subramanian, and Yusaku

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62414/#review185754 --- Ship it!

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/#review185755 --- Ship it! Needs a test. Other than Jonathan's comment, LGTM.

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62399/#review185653 ---

Re: Review Request 62402: Multiple fixes into branch-3.0-perf

2017-09-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62402/#review185662 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 19, 2017,

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62399/#review185652 --- Ship it! Ship It! - venkat sairam On Sept. 19, 2017, 5:06

Review Request 62402: Multiple fixes into branch-3.0-perf

2017-09-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62402/ --- Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Vitalyi

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62388/#review185654 ---

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk
> On Sept. 18, 2017, 6:34 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py > > Lines 88 (patched) > > > > > > Sounds like a very dirty

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Robert Levas
> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > > Lines 1176 (patched) > > > > > > Unless this would be used for something

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/#review185731 --- Do you plan to include the ability to extract constraint names

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62399/ --- (Updated Sept. 19, 2017, 3:18 p.m.) Review request for Ambari, Attila

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62399/ --- (Updated Sept. 19, 2017, 3:19 p.m.) Review request for Ambari, Attila

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62399/#review185668 --- Ship it! Ship It! - Gaurav Nagar On Sept. 19, 2017, 10:17

Re: Review Request 62402: Multiple fixes into branch-3.0-perf

2017-09-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62402/#review185670 --- Ship it! Ship It! - Attila Doroszlai On Sept. 19, 2017,

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62399/#review185671 --- Ship it! Ship It! - venkat sairam On Sept. 19, 2017, 10:17

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
> On Sept. 19, 2017, 11:44 p.m., Jonathan Hurley wrote: > > Do you plan to include the ability to extract constraint names from tables > > in this review? It's marked currently as preview... Yes. It's not a very simple thing, just wanted to make sure that we want it (otherwise, current patch

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk
> On Sept. 18, 2017, 6:34 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py > > Lines 88 (patched) > > > > > > Sounds like a very dirty

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62412/#review185711 --- Ship it! The Jira is marked for 2.6 and trunk - should you

Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62414/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-21999

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/#review185701 ---

Re: Review Request 62410: Revise log message for component version not found

2017-09-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62410/#review185693 --- Ship it! Ship It! - Jonathan Hurley On Sept. 19, 2017,

Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-21998

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62412/#review185702 --- Ship it! Ship It! - Robert Nettleton On Sept. 19, 2017,

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62412/#review185708 --- Ship it! Ship It! - Nate Cole On Sept. 19, 2017, 11:54

Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62412/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-21997

Review Request 62410: Revise log message for component version not found

2017-09-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62410/ --- Review request for Ambari and Jonathan Hurley. Bugs: AMBARI-21995

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62414/#review185717 --- Ship it! Ship It!

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Levas
> On Sept. 19, 2017, 12:58 p.m., Jonathan Hurley wrote: > > The Jira is marked for 2.6 and trunk - should you only put this fix into > > branch-2.6? Trunk is JDK 8 compatible... The previous depencency was version 0.1.7, which was older than the one in this patch, 0.1.10. I should have gone

Re: Review Request 62324: AMBARI-21955: Port Storm View from React.js to Vue.js

2017-09-19 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62324/#review185716 --- Ship it! Looks good. Tested by installing in Ambari along with

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Jonathan Hurley
> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > > Lines 1091-1092 (original), 1095-1099 (patched) > > > > > > Only if you are